Geolocation: rename Geoposition to Position to follow Spec

Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "[object Position]".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
Review-Url: https://codereview.chromium.org/2809843002
Cr-Commit-Position: refs/heads/master@{#463759}
Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429732250df0e9e

[mcasas, 2017-04-10 23:37:58]

Description was changed from

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition.idl to Position.idl and rippled that change through

BUG=708206
==========

to

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject.

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

[mcasas, 2017-04-11 02:31:18]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-04-11 02:31:29]

mcasas@chromium.org changed reviewers:
+ foolip@chromium.org

[mcasas, 2017-04-11 02:31:30]

foolip@ PTAL

[commit-bot: I haz the power, 2017-04-11 02:31:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-11 02:31:54]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-11 04:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:13:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2017-04-11 14:09:53]

lgtm

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/geolocation-api/position-string.html
(right):

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/geolocation-api/position-string.html:30:
shouldBe('position.toString()', '"[object Position]"');
"This change does not surface to the Web platform since Geoposition is a
NoInterfaceObject." is not strictly true, as shown here. Can you say instead
that the only effect of this is how the instances stringify?

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/geolocation/PositionCallback.idl (right):

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/geolocation/PositionCallback.idl:26: //
https://www.w3.org/TR/geolocation-API/#position-callback
Since you added the spec link, can you also add a "TODO(mcasas):
PositionCallback should be a callback function, not a callback interface"?
https://bugs.chromium.org/p/chromium/issues/detail?id=569301 is relevant, but
linking to no issue at all would be fine too.

[mcasas, 2017-04-11 16:14:35]

Description was changed from

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject.

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

to

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "Position.".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

[mcasas, 2017-04-11 16:22:16]

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/geolocation-api/position-string.html
(right):

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/geolocation-api/position-string.html:30:
shouldBe('position.toString()', '"[object Position]"');
On 2017/04/11 14:09:53, foolip_UTC7 wrote:
> "This change does not surface to the Web platform since Geoposition is a
> NoInterfaceObject." is not strictly true, as shown here. Can you say instead
> that the only effect of this is how the instances stringify?

Done updating CL description.

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/geolocation/PositionCallback.idl (right):

https://codereview.chromium.org/2809843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/geolocation/PositionCallback.idl:26: //
https://www.w3.org/TR/geolocation-API/#position-callback
On 2017/04/11 14:09:53, foolip_UTC7 wrote:
> Since you added the spec link, can you also add a "TODO(mcasas):
> PositionCallback should be a callback function, not a callback interface"?
> https://bugs.chromium.org/p/chromium/issues/detail?id=569301 is relevant, but
> linking to no issue at all would be fine too.

Done.

[mcasas, 2017-04-11 16:22:38]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-11 16:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2809843002/#ps40001
(title: "foolip@ comments")

[commit-bot: I haz the power, 2017-04-11 16:23:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-04-11 16:35:06]

Description was changed from

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "Position.".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

to

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "[object Position]".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

[foolip, 2017-04-11 16:35:37]

https://codereview.chromium.org/2809843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/geolocation/PositionCallback.idl (right):

https://codereview.chromium.org/2809843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/geolocation/PositionCallback.idl:29: //
interface, see https://crbug.com/569301
s/an interface/a callback interface/

[foolip, 2017-04-11 16:35:43]

The CQ bit was unchecked by foolip@chromium.org

[mcasas, 2017-04-11 16:49:02]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-11 16:49:03]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2809843002/#ps60001
(title: "comment correction")

[commit-bot: I haz the power, 2017-04-11 16:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 18:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:29:56]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mcasas, 2017-04-11 19:01:48]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-11 19:01:48]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2809843002/#ps80001
(title: "position-string-expected.txt")

[commit-bot: I haz the power, 2017-04-11 19:02:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:48:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491937308340890,
"parent_rev": "169bf5e0b403527a459c95bac5762a8190851589", "commit_rev":
"80d6493c57a368cf14c8c3eaf429732250df0e9e"}

[commit-bot: I haz the power, 2017-04-11 20:48:53]

Description was changed from

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "[object Position]".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206
==========

to

==========
Geolocation: rename Geoposition to Position to follow Spec

Renamed Geoposition to Position to align with the spec [1] and 
rippled that change through the files.  This change does not 
surface to the Web platform since Geoposition is a 
NoInterfaceObject _except_ for the way Geoposition is 
stringified, which changes to "[object Position]".

[1] https://www.w3.org/TR/geolocation-API/#position_interface

BUG=708206

Review-Url: https://codereview.chromium.org/2809843002
Cr-Commit-Position: refs/heads/master@{#463759}
Committed:
https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429...
==========

[commit-bot: I haz the power, 2017-04-11 20:48:55]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429...

[jbauman, 2017-04-11 21:46:13]

On 2017/04/11 20:48:55, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:80001) as
>
https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429...

something in this patch broke windows builds for me:
[23837/28612] CXX
obj/third_party/WebKit/Source/modules/modules/V8PositionCallback.obj
FAILED: obj/third_party/WebKit/Source/modules/modules/V8PositionCallback.obj
ninja -t msvc -e environment.x64 --
"C:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/third_party/WebKit/Source/modules/modules/V8PositionCallback.obj.rsp /c
gen/blink/bindings/modules/v8/V8PositionCallback.cpp
/Foobj/third_party/WebKit/Source/modules/modules/V8PositionCallback.obj
/Fd"obj/third_party/WebKit/Source/modules/modules_cc.pdb"
c:\src\chrome\src\third_party\webkit\source\modules\geolocation\positioncallback.h(33):
error C2371: 'blink::Position': redefinition; different basic types
c:\src\chrome\src\third_party\webkit\source\core\editing\position.h(224): note:
see declaration of 'blink::Position'
c:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\vc\include\type_traits(983):
error C2139: 'blink::Position': an undefined class is not allowed as an argument
to compiler intrinsic type trait '__is_base_of'
c:\src\chrome\src\third_party\webkit\source\modules\geolocation\positioncallback.h(33):
note: see declaration of 'blink::Position'

[mcasas, 2017-04-11 21:54:37]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2809783004/ by mcasas@chromium.org.

The reason for reverting is: Seems like Position was already taken (by
core\editing\position.h), reverting due to comment
#29

I'm puzzled that this didn't trigger _any_ bot :?.