Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2816713002: Removed old workaround for button padding from AccountSigninView (Closed)

Created:
3 years, 8 months ago by bsazonov
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed old workaround for button padding from AccountSigninView This CL removes workaround for the bug that was fixed long time ago. BUG=none Review-Url: https://codereview.chromium.org/2816713002 Cr-Commit-Position: refs/heads/master@{#464362} Committed: https://chromium.googlesource.com/chromium/src/+/89c72983c8a205ed7318ad2bd299b8d8aca77ea1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/android/java/res/layout/account_signin_view.xml View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bsazonov
Bernhard, please take a look. I've compared "before" and "after" screenshots - they match exactly.
3 years, 8 months ago (2017-04-12 12:36:28 UTC) #4
Bernhard Bauer
LGTM, thanks!
3 years, 8 months ago (2017-04-12 20:46:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816713002/1
3 years, 8 months ago (2017-04-13 09:42:42 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 09:47:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89c72983c8a205ed7318ad2bd299...

Powered by Google App Engine
This is Rietveld 408576698