Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

Issue 2816713002: Removed old workaround for button padding from AccountSigninView (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/account_signin_view.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
index 0e15bc30cd6d356fe0c80a72a7874c71ff81d53b..09300432545c1c0da03268ef29ac2b419c3b8627 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
@@ -20,7 +20,6 @@ import android.widget.TextView;
import com.google.android.gms.common.ConnectionResult;
-import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.Callback;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
@@ -163,11 +162,6 @@ public class AccountSigninView extends FrameLayout implements ProfileDownloader.
mNegativeButton = (Button) findViewById(R.id.negative_button);
mMoreButton = (Button) findViewById(R.id.more_button);
- // A workaround for Android support library ignoring padding set in XML. b/20307607
- int padding = getResources().getDimensionPixelSize(R.dimen.fre_button_padding);
- ApiCompatibilityUtils.setPaddingRelative(mPositiveButton, padding, 0, padding, 0);
- ApiCompatibilityUtils.setPaddingRelative(mNegativeButton, padding, 0, padding, 0);
-
// TODO(peconn): Ensure this is changed to R.string.cancel when used in Settings > Sign In.
mCancelButtonTextId = R.string.no_thanks;
« no previous file with comments | « chrome/android/java/res/layout/account_signin_view.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698