Revert of Don't delete obsolete prefs in incognito

Revert of Don't delete obsolete prefs in incognito (patchset #1 id:1 of https://codereview.chromium.org/2814653002/ )

Reason for revert:
This CL may be related to TwoClientAppListSyncTest.UpdateIncognitoEnableDisable failure

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F24685%2F%2B%2Frecipes%2Fsteps%2Fsync_integration_tests%2F0%2Fstdout

Original issue's description:
> Don't delete obsolete prefs in incognito
> 
> These deletes actually hit the underlying user prefs. In this case that was a
> no-op since those prefs had already been deleted, but pref writes do need to
> check for incognito.
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2814653002
> Cr-Commit-Position: refs/heads/master@{#463535}
> Committed: https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39620731fb85c8

TBR=raymes@chromium.org,tibell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654988
Review-Url: https://codereview.chromium.org/2816693003
Cr-Commit-Position: refs/heads/master@{#464014}
Committed: https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd1707ed207734bc1

[Peng, 2017-04-12 13:33:42]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2017-04-12 13:33:42]

Created Revert of Don't delete obsolete prefs in incognito

[commit-bot: I haz the power, 2017-04-12 13:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 14:16:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492004022009680, "parent_rev":
"996f406fabe039d6f6f44528b63e5e90b38d22cc", "commit_rev":
"1c913ae1fbb09dc8575d840dd1707ed207734bc1"}

[commit-bot: I haz the power, 2017-04-12 14:17:46]

Description was changed from

==========
Revert of Don't delete obsolete prefs in incognito (patchset #1 id:1 of
https://codereview.chromium.org/2814653002/ )

Reason for revert:
This CL may be related to TwoClientAppListSyncTest.UpdateIncognitoEnableDisable
failure

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...

Original issue's description:
> Don't delete obsolete prefs in incognito
> 
> These deletes actually hit the underlying user prefs. In this case that was a
> no-op since those prefs had already been deleted, but pref writes do need to
> check for incognito.
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2814653002
> Cr-Commit-Position: refs/heads/master@{#463535}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...

TBR=raymes@chromium.org,tibell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654988
==========

to

==========
Revert of Don't delete obsolete prefs in incognito (patchset #1 id:1 of
https://codereview.chromium.org/2814653002/ )

Reason for revert:
This CL may be related to TwoClientAppListSyncTest.UpdateIncognitoEnableDisable
failure

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...

Original issue's description:
> Don't delete obsolete prefs in incognito
> 
> These deletes actually hit the underlying user prefs. In this case that was a
> no-op since those prefs had already been deleted, but pref writes do need to
> check for incognito.
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2814653002
> Cr-Commit-Position: refs/heads/master@{#463535}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...

TBR=raymes@chromium.org,tibell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654988

Review-Url: https://codereview.chromium.org/2816693003
Cr-Commit-Position: refs/heads/master@{#464014}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd170...
==========

[commit-bot: I haz the power, 2017-04-12 14:17:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd170...

[raymes, 2017-04-12 21:56:45]

On 2017/04/12 14:17:47, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd170...

I would be quite surprised if this was related to that failure - do you know if
it has had an impact yet?

[Peng, 2017-04-12 22:29:53]

On 2017/04/12 21:56:45, raymes wrote:
> On 2017/04/12 14:17:47, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd170...
> 
> I would be quite surprised if this was related to that failure - do you know
if
> it has had an impact yet?

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

The reverting CL has been built in build 24755. After build 24755, I don't see
the failure till now.

[raymes, 2017-04-12 22:42:35]

On 2017/04/12 22:29:53, Peng wrote:
> On 2017/04/12 21:56:45, raymes wrote:
> > On 2017/04/12 14:17:47, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/1c913ae1fbb09dc8575d840dd170...
> > 
> > I would be quite surprised if this was related to that failure - do you know
> if
> > it has had an impact yet?
> 
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> The reverting CL has been built in build 24755. After build 24755, I don't see
> the failure till now.

Ok - let's see how it goes. It appears though, that the test may have been
failing even before that CL landed?
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...