Don't delete obsolete prefs in incognito

Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988
Review-Url: https://codereview.chromium.org/2814653002
Cr-Original-Commit-Position: refs/heads/master@{#463535}
Committed: https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39620731fb85c8
Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#465134}
Committed: https://chromium.googlesource.com/chromium/src/+/695e679d6a2068330d3e45e712a82de776e651b9

[tibell, 2017-04-11 02:34:32]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 02:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-04-11 02:35:55]

tibell@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-04-11 02:53:50]

lgtm

[commit-bot: I haz the power, 2017-04-11 03:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 03:53:03]

Dry run: This issue passed the CQ dry run.

[tibell, 2017-04-11 03:57:05]

The CQ bit was checked by tibell@chromium.org

[commit-bot: I haz the power, 2017-04-11 03:57:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:27:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491883025737760, "parent_rev":
"ddcf763b75989af36bab3d5ace11e5ee5f3adead", "commit_rev":
"d46617148d9a542238218ebafd39620731fb85c8"}

[commit-bot: I haz the power, 2017-04-11 04:28:40]

Description was changed from

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988
==========

to

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988

Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#463535}
Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...
==========

[commit-bot: I haz the power, 2017-04-11 04:28:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...

[Peng, 2017-04-12 13:33:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2816693003/ by penghuang@chromium.org.

The reason for reverting is: This CL may be related to
TwoClientAppListSyncTest.UpdateIncognitoEnableDisable failure

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi....

[tibell, 2017-04-12 23:58:16]

Description was changed from

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988

Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#463535}
Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...
==========

to

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988

Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#463535}
Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...
==========

[tibell, 2017-04-13 00:01:30]

I looked at the failures in
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...
that caused this to be reverted and they don't seem related.

I also ran all the relevant tests 20 times on my machine without any failures.

I'm assuming this is a flake. Lets reland and see.

[tibell, 2017-04-13 00:02:29]

On 2017/04/13 00:01:30, tibell wrote:
> I looked at the failures in
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...
> that caused this to be reverted and they don't seem related.
> 
> I also ran all the relevant tests 20 times on my machine without any failures.
> 
> I'm assuming this is a flake. Lets reland and see.

Also, as raymes pointed out in the revert CL, this seems to have been failing
before this CL:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

[tibell, 2017-04-13 00:02:34]

The CQ bit was checked by tibell@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:03:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:43:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tibell, 2017-04-18 03:07:19]

The CQ bit was checked by tibell@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:07:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:59:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492484839216870, "parent_rev":
"20e570ab5950d95673078e4edd1653faf97812b0", "commit_rev":
"695e679d6a2068330d3e45e712a82de776e651b9"}

[commit-bot: I haz the power, 2017-04-18 04:00:00]

Description was changed from

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988

Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#463535}
Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...
==========

to

==========
Don't delete obsolete prefs in incognito

These deletes actually hit the underlying user prefs. In this case that was a
no-op since those prefs had already been deleted, but pref writes do need to
check for incognito.

BUG=654988

Review-Url: https://codereview.chromium.org/2814653002
Cr-Original-Commit-Position: refs/heads/master@{#463535}
Committed:
https://chromium.googlesource.com/chromium/src/+/d46617148d9a542238218ebafd39...
Review-Url: https://codereview.chromium.org/2814653002
Cr-Commit-Position: refs/heads/master@{#465134}
Committed:
https://chromium.googlesource.com/chromium/src/+/695e679d6a2068330d3e45e712a8...
==========

[commit-bot: I haz the power, 2017-04-18 04:00:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/695e679d6a2068330d3e45e712a8...