Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix.

Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix.

The MessageLoopForIO isn't available until the service thread
is started. TaskTrackerPosix needs to be instantiated before
that so that SchedulerWorkerPools can be instantiated with a
pointer to it before the TaskScheduler is started.

BUG=690706
Review-Url: https://codereview.chromium.org/2816653003
Cr-Commit-Position: refs/heads/master@{#465586}
Committed: https://chromium.googlesource.com/chromium/src/+/2cc05d188ea62c172bf3bf54611671c95c380ab7

[fdoray, 2017-04-12 13:51:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 13:51:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-12 13:53:28]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-04-12 13:53:29]

PTAL

[commit-bot: I haz the power, 2017-04-12 13:54:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 13:54:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2017-04-12 19:17:35]

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler_impl.cc (right):

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler_impl.cc:177: #endif
Hmmm, not starting non-POSIX TaskTracker too??

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_tracker_posix.h (right):

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_tracker_posix.h:38: // Set in Start() and cannot be
read before Start().
s/cannot/must not/

[fdoray, 2017-04-13 12:26:14]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:26:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-13 12:27:44]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-13 12:29:08]

ptanl

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler_impl.cc (right):

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler_impl.cc:177: #endif
On 2017/04/12 19:17:34, gab wrote:
> Hmmm, not starting non-POSIX TaskTracker too??

Renamed Start() -> set_watch_file_descriptor_message_loop() to make it clearer
that Start() isn't required with non-POSIX TaskTracker.

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_tracker_posix.h (right):

https://codereview.chromium.org/2816653003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_tracker_posix.h:38: // Set in Start() and cannot be
read before Start().
On 2017/04/12 19:17:34, gab wrote:
> s/cannot/must not/

n/a. superseded by comment about external synchronization.

[commit-bot: I haz the power, 2017-04-13 12:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:31:15]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fdoray, 2017-04-13 13:45:23]

Description was changed from

==========
Separate the create and start phases in TaskTrackerPosix.

TaskTrackerPosix can't run tasks before it has been started.

BUG=690706
==========

to

==========
Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix.

The MessageLoopForIO isn't available until the service thread
is started. TaskTrackerPosix needs to be instantiated before
that so that SchedulerWorkerPools can be instantiated with a
pointer to it before the TaskScheduler is started.

BUG=690706
==========

[gab, 2017-04-13 15:31:39]

Ah, got it, that's indeed clearer, lgtm

[fdoray, 2017-04-19 12:44:27]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-04-19 12:44:34]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-04-19 12:44:39]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-04-19 12:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2816653003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-19 12:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 12:45:06]

This CL has an open dependency (Issue 2809163003 Patch 140001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[fdoray, 2017-04-19 12:45:17]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 12:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-19 14:00:21]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-04-19 14:00:25]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 14:06:57]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492610425142100,
"parent_rev": "1954b3e079198cc2b403c68c81516976e0c29c12", "commit_rev":
"2cc05d188ea62c172bf3bf54611671c95c380ab7"}

[commit-bot: I haz the power, 2017-04-19 14:07:05]

Description was changed from

==========
Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix.

The MessageLoopForIO isn't available until the service thread
is started. TaskTrackerPosix needs to be instantiated before
that so that SchedulerWorkerPools can be instantiated with a
pointer to it before the TaskScheduler is started.

BUG=690706
==========

to

==========
Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix.

The MessageLoopForIO isn't available until the service thread
is started. TaskTrackerPosix needs to be instantiated before
that so that SchedulerWorkerPools can be instantiated with a
pointer to it before the TaskScheduler is started.

BUG=690706

Review-Url: https://codereview.chromium.org/2816653003
Cr-Commit-Position: refs/heads/master@{#465586}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cc05d188ea62c172bf3bf546116...
==========

[commit-bot: I haz the power, 2017-04-19 14:07:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2cc05d188ea62c172bf3bf546116...