Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: base/task_scheduler/task_tracker_posix.h

Issue 2816653003: Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | base/task_scheduler/task_tracker_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_tracker_posix.h
diff --git a/base/task_scheduler/task_tracker_posix.h b/base/task_scheduler/task_tracker_posix.h
index f957e4c0daf4d8b402a9b0ef413365b48955be90..53859b21ab63654d9ef7d7a7e68580acd4558b0b 100644
--- a/base/task_scheduler/task_tracker_posix.h
+++ b/base/task_scheduler/task_tracker_posix.h
@@ -21,18 +21,27 @@ struct Task;
// A TaskTracker that instantiates a FileDescriptorWatcher in the scope in which
// a task runs. Used on all POSIX platforms except NaCl SFI.
+// set_watch_file_descriptor_message_loop() must be called before the
+// TaskTracker can run tasks.
class BASE_EXPORT TaskTrackerPosix : public TaskTracker {
public:
- // |watch_file_descriptor_message_loop| is used to setup FileDescriptorWatcher
- // in the scope in which a Task runs.
- TaskTrackerPosix(MessageLoopForIO* watch_file_descriptor_message_loop);
+ TaskTrackerPosix();
~TaskTrackerPosix();
+ // Sets the MessageLoopForIO with which to setup FileDescriptorWatcher in the
+ // scope in which tasks run. Must be called before starting to run tasks.
+ // External synchronization is required between a call to this and a call to
+ // RunTask().
+ void set_watch_file_descriptor_message_loop(
+ MessageLoopForIO* watch_file_descriptor_message_loop) {
+ watch_file_descriptor_message_loop_ = watch_file_descriptor_message_loop;
+ }
+
private:
// TaskTracker:
void PerformRunTask(std::unique_ptr<Task> task) override;
- MessageLoopForIO* const watch_file_descriptor_message_loop_;
+ MessageLoopForIO* watch_file_descriptor_message_loop_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(TaskTrackerPosix);
};
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | base/task_scheduler/task_tracker_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698