cros: Add flag to enable pin on sign-in screen.

cros: Add flag to enable pin on sign-in screen.

This will be used in a follow-up CL.

BUG=623344
Review-Url: https://codereview.chromium.org/2816643002
Cr-Commit-Position: refs/heads/master@{#465845}
Committed: https://chromium.googlesource.com/chromium/src/+/7447649fe53db18cd5080cabacebea84706d81c6

[jdufault, 2017-04-11 21:08:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 21:09:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:14:26]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2017-04-11 22:16:14]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:25:54]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-12 18:45:23]

Description was changed from

==========
cros: Add flag to enable pin on sign-in screen.

This will be used in a follow-up CL.

BUG=
==========

to

==========
cros: Add flag to enable pin on sign-in screen.

This will be used in a follow-up CL.

BUG=623344
==========

[jdufault, 2017-04-12 18:45:23]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-04-12 18:45:32]

Patchset #1 (id:1) has been deleted

[jdufault, 2017-04-12 22:36:43]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:42:23]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-15 00:06:11]

Patchset #1 (id:20001) has been deleted

[jdufault, 2017-04-15 00:08:31]

achuith@ PTAL

[achuithb, 2017-04-16 23:50:37]

lgtm

https://codereview.chromium.org/2816643002/diff/40001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2816643002/diff/40001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:2885: "Chromebook. After changing this flag
PIN needs to be set up again.";
And you really want to just use Chromebook here?

https://codereview.chromium.org/2816643002/diff/40001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2816643002/diff/40001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:314: // Enables or disables pin quick unlock.
Isn't PIN better since it's an abbreviation?

[jdufault, 2017-04-17 20:35:31]

jdufault@chromium.org changed reviewers:
+ isherman@chromium.org

[jdufault, 2017-04-17 20:36:08]

jdufault@chromium.org changed reviewers:
- isherman@chromium.org

[jdufault, 2017-04-17 20:36:09]

https://codereview.chromium.org/2816643002/diff/40001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2816643002/diff/40001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:2885: "Chromebook. After changing this flag
PIN needs to be set up again.";
On 2017/04/16 23:50:36, achuithb wrote:
> And you really want to just use Chromebook here?

Done.

https://codereview.chromium.org/2816643002/diff/40001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2816643002/diff/40001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:314: // Enables or disables pin quick unlock.
On 2017/04/16 23:50:36, achuithb wrote:
> Isn't PIN better since it's an abbreviation?

Done.

[jdufault, 2017-04-17 20:36:21]

jdufault@chromium.org changed reviewers:
+ isherman@chromium.org

[jdufault, 2017-04-17 20:36:48]

isherman@ PTAL at tools/metrics/histograms/histograms.xml

[jdufault, 2017-04-17 20:36:51]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 20:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:44:48]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-04-17 21:59:36]

histograms.xml lgtm

[jdufault, 2017-04-17 22:20:17]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-04-17 22:20:18]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2816643002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-17 22:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 22:20:43]

This CL has an open dependency (Issue 2814863002 Patch 80001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[jdufault, 2017-04-20 00:14:23]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:14:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:20:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492647263048790,
"parent_rev": "57ed4544b704badc3e547fc87b06b4ddcabe2869", "commit_rev":
"7447649fe53db18cd5080cabacebea84706d81c6"}

[commit-bot: I haz the power, 2017-04-20 01:20:21]

Description was changed from

==========
cros: Add flag to enable pin on sign-in screen.

This will be used in a follow-up CL.

BUG=623344
==========

to

==========
cros: Add flag to enable pin on sign-in screen.

This will be used in a follow-up CL.

BUG=623344

Review-Url: https://codereview.chromium.org/2816643002
Cr-Commit-Position: refs/heads/master@{#465845}
Committed:
https://chromium.googlesource.com/chromium/src/+/7447649fe53db18cd5080cabaceb...
==========

[commit-bot: I haz the power, 2017-04-20 01:20:24]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7447649fe53db18cd5080cabaceb...