Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2816593003: Roll clang 298539:299960. (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 298539:299960. This includes r299782 which allows for using _interlockedbittestandset without including intrin.h, and a configuration change which means Clang no longer implicitly passes -Wl,--build-id to the linker by default. BUG=709521, 622775, 708769 Review-Url: https://codereview.chromium.org/2816593003 Cr-Commit-Position: refs/heads/master@{#464027} Committed: https://chromium.googlesource.com/chromium/src/+/a6f580ee29385647f86e82efb9ab1192c6b0f849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
hans
The linux_chromium_chromeos_asan_rel_ng failure seems to be addressed by https://codereview.chromium.org/2816513002
3 years, 8 months ago (2017-04-11 21:03:37 UTC) #4
Nico
lgtm
3 years, 8 months ago (2017-04-11 21:07:28 UTC) #6
hans
The linux_chromium_msan_rel_ng failure is crbug.com/710152. It's been fixed in V8 but apparently not rolled in ...
3 years, 8 months ago (2017-04-11 22:37:54 UTC) #7
hans
The V8 roll we need is in the CQ here: https://codereview.chromium.org/2815603003/
3 years, 8 months ago (2017-04-11 23:24:04 UTC) #10
hans
The new linux_chromium_chromeos_asan_rel_ng run has green browser_tests, but instead views_unittests failed -- but those passed ...
3 years, 8 months ago (2017-04-12 02:50:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816593003/1
3 years, 8 months ago (2017-04-12 15:04:19 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 15:17:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6f580ee29385647f86e82efb9ab...

Powered by Google App Engine
This is Rietveld 408576698