Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2816533003: Reland of Enable spec-compliant algorithm for MediaStream video constraints by default (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #1 id:1 of https://codereview.chromium.org/2810913007/ ) Reason for revert: The defaults were changed to the same as the old algorithm in subsequent patches. Original issue's description: > Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ ) > > Reason for revert: > Regressed performance_browser_tests 21-93% (see crbug.com/710187). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead. > > > Original issue's description: > > Enable spec-compliant algorithm for MediaStream video constraints by default > > > > BUG=657733 > > > > Review-Url: https://codereview.chromium.org/2793053002 > > Cr-Commit-Position: refs/heads/master@{#462575} > > Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42 > > TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=657733 > > Review-Url: https://codereview.chromium.org/2810913007 > Cr-Commit-Position: refs/heads/master@{#463913} > Committed: https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08 TBR=avi@chromium.org,stkhapugin@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Guido Urdaneta
Created Reland of Enable spec-compliant algorithm for MediaStream video constraints by default
3 years, 8 months ago (2017-04-12 03:29:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816533003/1
3 years, 8 months ago (2017-04-12 03:29:37 UTC) #3
Guido Urdaneta
3 years, 8 months ago (2017-04-12 07:35:39 UTC) #7
Message was sent while issue was closed.
This landed accidentally, but was reverted again in
https://codereview.chromium.org/2810143002/

Powered by Google App Engine
This is Rietveld 408576698