Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2793053002:
Enable spec-compliant algorithm for MediaStream video constraints by default (Closed)
|
Created:
3 years, 8 months ago by Guido Urdaneta Modified:
3 years, 8 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable spec-compliant algorithm for MediaStream video constraints by default
BUG=657733
Review-Url: https://codereview.chromium.org/2793053002
Cr-Commit-Position: refs/heads/master@{#462575}
Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42
Patch Set 1 #Patch Set 2 : no changes. rebase to remove dependency on old patchset #Messages
Total messages: 29 (20 generated)
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
guidou@chromium.org changed reviewers: + jochen@chromium.org
Hi, PTAL
Description was changed from ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=653377 ========== to ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=653377 ==========
guidou@chromium.org changed reviewers: + avi@chromium.org - jochen@chromium.org
avi@: Can you take a look at this 1-word CL?
lgtm Progress! Good luck.
On 2017/04/06 16:06:19, Avi (slow and ooo 10-23 April) wrote: > lgtm > > Progress! > > Good luck. thanks!
The CQ bit was checked by guidou@chromium.org
The CQ bit was unchecked by guidou@chromium.org
The CQ bit was checked by guidou@chromium.org
The CQ bit was unchecked by guidou@chromium.org
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2793053002/#ps40001 (title: "no changes. rebase to remove dependency on old patchset")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491496304498090,
"parent_rev": "a07df2f5433924466195f42943f5224dfc74185d", "commit_rev":
"73d1c7107a41b474c6fed9292ff41f7ce3429a42"}
Message was sent while issue was closed.
Description was changed from ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=653377 ========== to ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=653377 Review-Url: https://codereview.chromium.org/2793053002 Cr-Commit-Position: refs/heads/master@{#462575} Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff4...
Message was sent while issue was closed.
stkhapugin@chromium.org changed reviewers: + stkhapugin@chromium.org
Message was sent while issue was closed.
Hi, I think you've put issue 653377 by mistake in your CL description. :)
Message was sent while issue was closed.
On 2017/04/07 09:03:15, stkhapugin wrote: > Hi, I think you've put issue 653377 by mistake in your CL description. :) Thanks for pointing that out, stkhapugin. The correct bug number is 657733.
Message was sent while issue was closed.
Description was changed from ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=653377 Review-Url: https://codereview.chromium.org/2793053002 Cr-Commit-Position: refs/heads/master@{#462575} Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff4... ========== to ========== Enable spec-compliant algorithm for MediaStream video constraints by default BUG=657733 Review-Url: https://codereview.chromium.org/2793053002 Cr-Commit-Position: refs/heads/master@{#462575} Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff4... ==========
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2810913007/ by miu@chromium.org. The reason for reverting is: Regressed performance_browser_tests 21-93% (see crbug.com/710187). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead. . |
