Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2810913007: Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (Closed)

Created:
3 years, 8 months ago by miu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ ) Reason for revert: Regressed performance_browser_tests 21-93% (see crbug.com/710187). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead. Original issue's description: > Enable spec-compliant algorithm for MediaStream video constraints by default > > BUG=657733 > > Review-Url: https://codereview.chromium.org/2793053002 > Cr-Commit-Position: refs/heads/master@{#462575} > Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42 TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=657733 Review-Url: https://codereview.chromium.org/2810913007 Cr-Commit-Position: refs/heads/master@{#463913} Committed: https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
miu
Created Revert of Enable spec-compliant algorithm for MediaStream video constraints by default
3 years, 8 months ago (2017-04-12 02:01:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810913007/1
3 years, 8 months ago (2017-04-12 02:02:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08
3 years, 8 months ago (2017-04-12 03:09:30 UTC) #6
Guido Urdaneta
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2816533003/ by guidou@chromium.org. ...
3 years, 8 months ago (2017-04-12 03:29:11 UTC) #7
Guido Urdaneta
On 2017/04/12 03:29:11, Guido Urdaneta wrote: > A revert of this CL (patchset #1 id:1) ...
3 years, 8 months ago (2017-04-12 03:42:47 UTC) #8
Guido Urdaneta
3 years, 8 months ago (2017-04-12 17:46:52 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2814813004/ by guidou@chromium.org.

The reason for reverting is: The fix for the issue has landed..

Powered by Google App Engine
This is Rietveld 408576698