Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2816533002: [SPv1] Fix return value for "fallback" case of inverted clips. (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix return value for "fallback" case of inverted clips. Also changed LocalToAncestorVisualRect to return a const reference, which was an oversight in previous CLs. BUG=704077 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2816533002 Cr-Commit-Position: refs/heads/master@{#463910} Committed: https://chromium.googlesource.com/chromium/src/+/64eb4f544d1b3b778f5b915de00e1e6cdced0aa3

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Messages

Total messages: 30 (20 generated)
chrishtr
3 years, 8 months ago (2017-04-11 16:34:08 UTC) #6
trchen
It is unfortunate we need to workaround SPv1 bugs... but the hole would be too ...
3 years, 8 months ago (2017-04-11 20:35:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816533002/20001
3 years, 8 months ago (2017-04-11 21:18:56 UTC) #13
chrishtr
Updated to do a better job - rather than returning an infinite rect, returns an ...
3 years, 8 months ago (2017-04-11 21:29:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816533002/40001
3 years, 8 months ago (2017-04-11 21:29:53 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/269664) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-11 22:25:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816533002/60001
3 years, 8 months ago (2017-04-11 23:23:33 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-04-12 01:25:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816533002/60001
3 years, 8 months ago (2017-04-12 01:58:41 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 03:04:33 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/64eb4f544d1b3b778f5b915de00e...

Powered by Google App Engine
This is Rietveld 408576698