Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

Issue 2816533002: [SPv1] Fix return value for "fallback" case of inverted clips. (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
index c627863d39025380cda48c0d55470386eca5866f..e44d8d000586d1a60e23b150788eee5af95446e2 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
@@ -119,7 +119,7 @@ void GeometryMapper::LocalToAncestorVisualRectInternal(
FloatRect mapped_rect = transform_matrix.MapRect(rect_to_map.Rect());
- FloatClipRect clip_rect =
+ const FloatClipRect& clip_rect =
LocalToAncestorClipRectInternal(local_state.Clip(), ancestor_state.Clip(),
ancestor_state.Transform(), success);
@@ -136,6 +136,7 @@ void GeometryMapper::LocalToAncestorVisualRectInternal(
// --enable-prefer-compositing-to-lcd-text) for details.
// Ignore it for SPv1 for now.
success = true;
+ rect_to_map.SetRect(mapped_rect);
}
}
@@ -213,11 +214,11 @@ void GeometryMapper::AncestorToLocalRect(
rect = transform_matrix.Inverse().MapRect(rect);
}
-FloatClipRect GeometryMapper::LocalToAncestorClipRect(
+const FloatClipRect& GeometryMapper::LocalToAncestorClipRect(
const PropertyTreeState& local_state,
const PropertyTreeState& ancestor_state) {
bool success = false;
- FloatClipRect result =
+ const FloatClipRect& result =
LocalToAncestorClipRectInternal(local_state.Clip(), ancestor_state.Clip(),
ancestor_state.Transform(), success);

Powered by Google App Engine
This is Rietveld 408576698