Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 281653003: DRAFT CL: Add FrameNavigationEntry and track subframe session histories.

Created:
6 years, 7 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Visibility:
Public.

Description

DRAFT CL: Add FrameNavigationEntry and track subframe session histories. Explores what logic we need to track subframe navigations in the browser process. BUG=236848 Do not commit.

Patch Set 1 #

Patch Set 2 : Rebase and add unit tests. #

Patch Set 3 : Support Back in a subframe; add test #

Patch Set 4 : Rebase #

Patch Set 5 : Use frame states to support more back/forward #

Patch Set 6 : Rebase (not working) #

Patch Set 7 : Fix 4 crashes and a test #

Patch Set 8 : Rebase after landing some parts #

Patch Set 9 : Rebase #

Patch Set 10 : Move FNE to scoped_refptrs on NE and FTN #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+886 lines, -343 lines) Patch
M content/browser/frame_host/frame_navigation_entry.h View 1 2 3 4 5 6 7 8 9 10 5 chunks +29 lines, -1 line 0 comments Download
M content/browser/frame_host/frame_navigation_entry.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +15 lines, -9 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_delegate.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 2 3 4 5 6 7 8 9 7 chunks +45 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 3 4 5 6 7 8 9 10 34 chunks +319 lines, -74 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +127 lines, -51 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 2 3 4 5 6 7 8 9 10 10 chunks +35 lines, -18 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 3 4 5 6 7 8 9 10 12 chunks +55 lines, -15 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigator.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +23 lines, -18 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +11 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +6 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +115 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +6 lines, -24 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/frame_navigate_params.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/history_controller.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/history_controller.cc View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M content/renderer/history_entry.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/history_entry.cc View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +28 lines, -8 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
Charlie Reis
Patchset #6 (id:100001) has been deleted
5 years, 10 months ago (2015-02-20 00:09:28 UTC) #1
Charlie Reis
5 years, 9 months ago (2015-03-03 17:39:43 UTC) #2 
Patchset #9 (id:180001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698