Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 281653003: DRAFT CL: Add FrameNavigationEntry and track subframe session histories. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "content/browser/frame_host/navigation_entry_impl.h" 7 #include "content/browser/frame_host/navigation_entry_impl.h"
8 #include "content/browser/web_contents/web_contents_impl.h" 8 #include "content/browser/web_contents/web_contents_impl.h"
9 #include "content/browser/web_contents/web_contents_view.h" 9 #include "content/browser/web_contents/web_contents_view.h"
10 #include "content/common/frame_messages.h" 10 #include "content/common/frame_messages.h"
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 int64 frame_tree_node_id = root->child_at(0)->frame_tree_node_id(); 350 int64 frame_tree_node_id = root->child_at(0)->frame_tree_node_id();
351 EXPECT_NE(-1, frame_tree_node_id); 351 EXPECT_NE(-1, frame_tree_node_id);
352 352
353 // Navigate with the subframe's FrameTreeNode ID. 353 // Navigate with the subframe's FrameTreeNode ID.
354 const GURL url(test_server()->GetURL("files/title1.html")); 354 const GURL url(test_server()->GetURL("files/title1.html"));
355 OpenURLParams params(url, Referrer(), frame_tree_node_id, CURRENT_TAB, 355 OpenURLParams params(url, Referrer(), frame_tree_node_id, CURRENT_TAB,
356 ui::PAGE_TRANSITION_LINK, true); 356 ui::PAGE_TRANSITION_LINK, true);
357 shell()->web_contents()->OpenURL(params); 357 shell()->web_contents()->OpenURL(params);
358 358
359 // Make sure the NavigationEntry ends up with the FrameTreeNode ID. 359 // Make sure the NavigationEntry ends up with the FrameTreeNode ID.
360 // TODO(creis): Update this test for the new approach.
360 NavigationController* controller = &shell()->web_contents()->GetController(); 361 NavigationController* controller = &shell()->web_contents()->GetController();
361 EXPECT_TRUE(controller->GetPendingEntry()); 362 EXPECT_TRUE(controller->GetPendingEntry());
362 EXPECT_EQ(frame_tree_node_id, 363 //EXPECT_EQ(frame_tree_node_id,
363 NavigationEntryImpl::FromNavigationEntry( 364 // NavigationEntryImpl::FromNavigationEntry(
364 controller->GetPendingEntry())->frame_tree_node_id()); 365 // controller->GetPendingEntry())->frame_tree_node_id());
365 } 366 }
366 367
367 IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, 368 IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,
368 AppendingFrameInWebUIDoesNotCrash) { 369 AppendingFrameInWebUIDoesNotCrash) {
369 const GURL kWebUIUrl("chrome://tracing"); 370 const GURL kWebUIUrl("chrome://tracing");
370 const char kJSCodeForAppendingFrame[] = 371 const char kJSCodeForAppendingFrame[] =
371 "document.body.appendChild(document.createElement('iframe'));"; 372 "document.body.appendChild(document.createElement('iframe'));";
372 373
373 NavigateToURL(shell(), kWebUIUrl); 374 NavigateToURL(shell(), kWebUIUrl);
374 375
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 scoped_ptr<FirstVisuallyNonEmptyPaintObserver> observer( 636 scoped_ptr<FirstVisuallyNonEmptyPaintObserver> observer(
636 new FirstVisuallyNonEmptyPaintObserver(shell())); 637 new FirstVisuallyNonEmptyPaintObserver(shell()));
637 638
638 NavigateToURL(shell(), embedded_test_server()->GetURL("/title1.html")); 639 NavigateToURL(shell(), embedded_test_server()->GetURL("/title1.html"));
639 640
640 observer->WaitForDidFirstVisuallyNonEmptyPaint(); 641 observer->WaitForDidFirstVisuallyNonEmptyPaint();
641 ASSERT_TRUE(observer->did_fist_visually_non_empty_paint_); 642 ASSERT_TRUE(observer->did_fist_visually_non_empty_paint_);
642 } 643 }
643 644
644 } // namespace content 645 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698