content/renderer/render_frame_proxy.cc - Issue 281653003: DRAFT CL: Add FrameNavigationEntry and track subframe session histories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 281653003: DRAFT CL: Add FrameNavigationEntry and track subframe session histories. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_proxy.cc

diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc

index ae6d699ae739783c76a70f4dcb05fcd246c45949..f76ab7149792a6f2284ab5c41e0992ba3510ea21 100644

--- a/content/renderer/render_frame_proxy.cc

+++ b/content/renderer/render_frame_proxy.cc

@@ -304,8 +304,9 @@ void RenderFrameProxy::OnDidUpdateName(const std::string& name) {

}

void RenderFrameProxy::frameDetached() {

- if (web_frame_->parent())

- web_frame_->parent()->removeChild(web_frame_);

+ // TODO(creis): See http://crbug.com/433012.

+ //if (web_frame_->parent())

+ // web_frame_->parent()->removeChild(web_frame_);

web_frame_->close();

delete this;

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »