Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2604)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java

Issue 2816513004: Web payments metric for multiple show() calls. (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
index d461d738683ce82376ae19f4c49bb2a5c9581076..a265a3a9c95534bfc00cc8e438e192bc305cce10 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.payments;
import android.support.test.filters.MediumTest;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.AutofillTestHelper;
@@ -41,6 +42,16 @@ public class PaymentRequestShowTwiceTest extends PaymentRequestTestBase {
throws InterruptedException, ExecutionException, TimeoutException {
triggerUIAndWait(mReadyToPay);
expectResultContains(new String[] {"Second request: AbortError: Request cancelled"});
+
+ // The web payments UI was not aborted.
+ assertOnlySpecificAbortMetricLogged(-1 /* none */);
+
+ // The UI was never shown due to another web payments UI already showing.
+ assertEquals(1,
+ RecordHistogram.getHistogramValueCountForTesting(
+ "PaymentRequest.CheckoutFunnel.NoShow",
+ PaymentRequestMetrics.NO_SHOW_CONCURRENT_REQUESTS));
+
clickAndWait(R.id.close_button, mDismissed);
}
}

Powered by Google App Engine
This is Rietveld 408576698