Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Issue 2816513004: Web payments metric for multiple show() calls. (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
index 5f199ec99691983cbec0a14182601687f7bc8547..c01005040f3ffeb7e61a2d00458a8d98c01020ec 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
@@ -15,6 +15,7 @@ import android.widget.EditText;
import android.widget.Spinner;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.base.test.util.UrlUtils;
@@ -42,6 +43,7 @@ import org.chromium.payments.mojom.PaymentMethodData;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.Callable;
@@ -727,6 +729,21 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT
});
}
+ /**
+ * Asserts that only the specified reason for abort is logged.
+ *
+ * @param abortReason The only bucket in the abort histogram that should have a record.
+ */
+ protected void assertOnlySpecificAbortMetricLogged(int abortReason) {
+ for (int i = 0; i < PaymentRequestMetrics.ABORT_REASON_MAX; ++i) {
+ assertEquals(
+ String.format(Locale.getDefault(), "Found %d instead of %d", i, abortReason),
+ (i == abortReason ? 1 : 0),
+ RecordHistogram.getHistogramValueCountForTesting(
+ "PaymentRequest.CheckoutFunnel.Aborted", i));
+ }
+ }
+
@Override
public void onPaymentRequestReadyForInput(PaymentRequestUI ui) {
ThreadUtils.assertOnUiThread();

Powered by Google App Engine
This is Rietveld 408576698