Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

Issue 2816513004: Web payments metric for multiple show() calls. (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
index 300fad6731e5106da84e85f1f3330107117a3848..56b3db298b48b628c3f0008d22a2bd219a636ded 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.payments;
-import android.annotation.SuppressLint;
import android.content.DialogInterface;
import android.support.test.filters.MediumTest;
@@ -334,22 +333,6 @@ public class PaymentRequestMetricsTest extends PaymentRequestTestBase {
}
/**
- * Asserts that only the specified reason for abort is logged.
- *
- * @param abortReason The only bucket in the abort histogram that should have a record.
- */
- // TODO(crbug.com/635567): Fix this properly.
- @SuppressLint("DefaultLocale")
- private void assertOnlySpecificAbortMetricLogged(int abortReason) {
- for (int i = 0; i < PaymentRequestMetrics.ABORT_REASON_MAX; ++i) {
- assertEquals(String.format("Found %d instead of %d", i, abortReason),
- (i == abortReason ? 1 : 0),
- RecordHistogram.getHistogramValueCountForTesting(
- "PaymentRequest.CheckoutFunnel.Aborted", i));
- }
- }
-
- /**
* Asserts that only the specified selected payment method is logged.
*
* @param paymentMethod The only bucket in the selected payment method histogram that should

Powered by Google App Engine
This is Rietveld 408576698