Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2816373004: [inspector] don't enter to debugger context for PromiseEventOccurred (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] don't enter to debugger context for PromiseEventOccurred Inspector doesn't use debugger context and this entering only slow down our async instrumentation. BUG=v8:6189 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2816373004 Cr-Commit-Position: refs/heads/master@{#44665} Committed: https://chromium.googlesource.com/v8/v8/+/88116e998f1073976b57f1f990c57deca1b2b131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M src/debug/debug.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/v8-debugger.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/v8-debugger.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
kozy
Yang, please take a look.
3 years, 8 months ago (2017-04-17 07:26:46 UTC) #1
Yang
lgtm
3 years, 8 months ago (2017-04-17 07:29:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816373004/1
3 years, 8 months ago (2017-04-17 18:50:41 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 18:53:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/88116e998f1073976b57f1f990c57deca1b...

Powered by Google App Engine
This is Rietveld 408576698