mac: Enable -Wunused-const-variable.

mac: Enable -Wunused-const-variable.

BUG=307668
TBR=hans@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229395

[commit-bot: I haz the power, 2013-10-18 05:37:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/28163003/110001

[Nico, 2013-10-18 13:17:50]

Committed patchset #4 manually as r229395.

[tonyg, 2013-10-18 20:52:13]

I think this patch broke the perf bots (or possibly
https://codereview.chromium.org/27374002).

http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/51227...

/b/build/slave/chromium-rel-mac-builder/build/src/chrome/renderer/media/chrome_key_systems.cc:39:12:
error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-variable,24]
 const char kAvc1Avc3[] = "avc1,avc3";
            ^
1 error generated.


** BUILD FAILED **

[Nico, 2013-10-18 21:00:46]

All main waterfall bots look happy. Does the perf waterfall build stuff
that isn't build on the main waterfall? Building the 'all' target locally
also worked without issues.


On Fri, Oct 18, 2013 at 1:52 PM, <tonyg@chromium.org> wrote:

> I think this patch broke the perf bots (or possibly
>
https://codereview.chromium.**org/27374002<https://codereview.chromium.org/27...
> ).
>
> http://build.chromium.org/p/**chromium.perf/builders/Mac%**
>
20Builder/builds/51227/steps/**compile/logs/stdio<http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/51227/steps/compile/logs/stdio>
>
> /b/build/slave/chromium-rel-**mac-builder/build/src/chrome/**
> renderer/media/chrome_key_**systems.cc:39:12:
> error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-**variable,24]
>  const char kAvc1Avc3[] = "avc1,avc3";
>             ^
> 1 error generated.
>
>
> ** BUILD FAILED **
>
>
https://codereview.chromium.**org/28163003/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-10-18 21:01:50]

Oh, I guess the CQ landed https://codereview.chromium.org/27374002 with
tryjobs that didn't have my change yet maybe? That's something that
sometimes happens when new warnings get turned on, there's always a window
where new stuff can creep in. Seems easy enough to fix though, I'll send
you a CL.


On Fri, Oct 18, 2013 at 2:00 PM, Nico Weber <thakis@chromium.org> wrote:

> All main waterfall bots look happy. Does the perf waterfall build stuff
> that isn't build on the main waterfall? Building the 'all' target locally
> also worked without issues.
>
>
> On Fri, Oct 18, 2013 at 1:52 PM, <tonyg@chromium.org> wrote:
>
>> I think this patch broke the perf bots (or possibly
>>
https://codereview.chromium.**org/27374002<https://codereview.chromium.org/27...
>> ).
>>
>> http://build.chromium.org/p/**chromium.perf/builders/Mac%**
>>
20Builder/builds/51227/steps/**compile/logs/stdio<http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/51227/steps/compile/logs/stdio>
>>
>> /b/build/slave/chromium-rel-**mac-builder/build/src/chrome/**
>> renderer/media/chrome_key_**systems.cc:39:12:
>> error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-**variable,24]
>>  const char kAvc1Avc3[] = "avc1,avc3";
>>             ^
>> 1 error generated.
>>
>>
>> ** BUILD FAILED **
>>
>>
https://codereview.chromium.**org/28163003/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[acolwell GONE FROM CHROMIUM, 2013-10-18 21:08:36]

On 2013/10/18 20:52:13, tonyg wrote:
> I think this patch broke the perf bots (or possibly
> https://codereview.chromium.org/27374002).
> 
>
http://build.chromium.org/p/chromium.perf/builders/Mac%2520Builder/builds/512...
> 
>
/b/build/slave/chromium-rel-mac-builder/build/src/chrome/renderer/media/chrome_key_systems.cc:39:12:
> error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-variable,24]
>  const char kAvc1Avc3[] = "avc1,avc3";
>             ^
> 1 error generated.
> 
> 
> ** BUILD FAILED **

The constant is referenced on line 167. Unless the compiler is doing crazy
cross-function optimization, I don't see why it would report this.

[Nico, 2013-10-18 21:11:27]

This warning is emitted prior to optimizations.

The perf bot gyps with "ffmpeg_branding=Chrome proprietary_codecs=1" which
is probably why it's special. I'm trying to repro this locally.


On Fri, Oct 18, 2013 at 2:08 PM, <acolwell@chromium.org> wrote:

> On 2013/10/18 20:52:13, tonyg wrote:
>
>> I think this patch broke the perf bots (or possibly
>>
https://codereview.chromium.**org/27374002<https://codereview.chromium.org/27...
>> ).
>>
>
>
> http://build.chromium.org/p/**chromium.perf/builders/Mac%**
>
2520Builder/builds/51227/**steps/compile/logs/stdio<http://build.chromium.org/p/chromium.perf/builders/Mac%2520Builder/builds/51227/steps/compile/logs/stdio>
>
>
>
> /b/build/slave/chromium-rel-**mac-builder/build/src/chrome/**
> renderer/media/chrome_key_**systems.cc:39:12:
>
>> error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-**variable,24]
>>   const char kAvc1Avc3[] = "avc1,avc3";
>>              ^
>> 1 error generated.
>>
>
>
>  ** BUILD FAILED **
>>
>
> The constant is referenced on line 167. Unless the compiler is doing crazy
> cross-function optimization, I don't see why it would report this.
>
>
https://codereview.chromium.**org/28163003/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-10-18 21:28:26]

https://codereview.chromium.org/28053006


On Fri, Oct 18, 2013 at 2:11 PM, Nico Weber <thakis@chromium.org> wrote:

> This warning is emitted prior to optimizations.
>
> The perf bot gyps with "ffmpeg_branding=Chrome proprietary_codecs=1" which
> is probably why it's special. I'm trying to repro this locally.
>
>
> On Fri, Oct 18, 2013 at 2:08 PM, <acolwell@chromium.org> wrote:
>
>> On 2013/10/18 20:52:13, tonyg wrote:
>>
>>> I think this patch broke the perf bots (or possibly
>>>
https://codereview.chromium.**org/27374002<https://codereview.chromium.org/27...
>>> ).
>>>
>>
>>
>> http://build.chromium.org/p/**chromium.perf/builders/Mac%**
>>
2520Builder/builds/51227/**steps/compile/logs/stdio<http://build.chromium.org/p/chromium.perf/builders/Mac%2520Builder/builds/51227/steps/compile/logs/stdio>
>>
>>
>>
>> /b/build/slave/chromium-rel-**mac-builder/build/src/chrome/**
>> renderer/media/chrome_key_**systems.cc:39:12:
>>
>>> error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-**
>>> variable,24]
>>>   const char kAvc1Avc3[] = "avc1,avc3";
>>>              ^
>>> 1 error generated.
>>>
>>
>>
>>  ** BUILD FAILED **
>>>
>>
>> The constant is referenced on line 167. Unless the compiler is doing crazy
>> cross-function optimization, I don't see why it would report this.
>>
>>
https://codereview.chromium.**org/28163003/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.