Add support for avc3 codec string.

Add support for avc3 codec string.

The avc3 codec string is used for H.264 content where the SPS & PPS are
included at the beginning of each access point instead of in the file
headers. This change just allows these streams to be played since our
decoders already support this. In fact, our avc1 code essentially creates
avc3 style streams for the decoder anyways.

BUG=306545
TEST=PipelineIntegrationTest.BasicPlayback_MediaSource_VideoOnly_MP4_AVC3

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229347

[scherkus (not reviewing), 2013-10-15 20:04:33]

patch upload is messed up -- try again

[acolwell GONE FROM CHROMIUM, 2013-10-15 20:37:16]

On 2013/10/15 20:04:33, scherkus wrote:
> patch upload is messed up -- try again

Done

[scherkus (not reviewing), 2013-10-15 22:51:12]

lgtm

https://codereview.chromium.org/27374002/diff/14001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/27374002/diff/14001/net/base/mime_util.cc#new...
net/base/mime_util.cc:318: "avc3",
this affects canplaytype -- what about a layout test?

[acolwell GONE FROM CHROMIUM, 2013-10-15 23:04:11]

https://codereview.chromium.org/27374002/diff/14001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/27374002/diff/14001/net/base/mime_util.cc#new...
net/base/mime_util.cc:318: "avc3",
On 2013/10/15 22:51:12, scherkus wrote:
> this affects canplaytype -- what about a layout test?

I'll add layout tests in another CL.

[commit-bot: I haz the power, 2013-10-15 23:08:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/14001

[ddorwin, 2013-10-15 23:41:27]

https://codereview.chromium.org/27374002/diff/14001/content/renderer/media/cr...
File content/renderer/media/crypto/key_systems.cc (right):

https://codereview.chromium.org/27374002/diff/14001/content/renderer/media/cr...
content/renderer/media/crypto/key_systems.cc:49:
info.supported_types.push_back(std::make_pair(kVideoMp4, kMp4aAvc1Avc3));
We should also update chrome_key_systems.cc. External Clear Key certainly
supports it. I'm not sure about specific implementations of other key systems.

Also, there are content_browsertests and browser_tests that cover this and those
key systems, respectively.

[commit-bot: I haz the power, 2013-10-15 23:41:55]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[acolwell GONE FROM CHROMIUM, 2013-10-16 16:58:27]

ddorwin@ : Please key system & browser test changes. I believe everything should
support avc3 since the MP4StreamParser essentially outputs avc3 streams to the
decoder even in the avc1 case. You'll just get fewer config changes.

akalin@: Please owners review net/base/mime_util.cc change.

[ddorwin, 2013-10-16 17:31:30]

lgtm % comments

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:457:
"video/mp4", aac_codec(), kPrefixedClearKey));
should this one be avc3?

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:459:
EXPECT_PROPRIETARY(IsSupportedKeySystemWithMediaMimeType(
indentation and extra blank line

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:492:
"audio/mp4", avc1_and_aac_codecs(), kPrefixedClearKey));
add here for consistency with ECK.

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:816:
EXPECT_WVAVC1AAC(IsSupportedKeySystemWithMediaMimeType(
add avc3_codec?

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:865:
"audio/mp4", avc1_and_aac_codecs(), kWidevineAlpha));
add here for consistency with ECK.

[akalin, 2013-10-16 18:09:06]

net lgtm

[acolwell GONE FROM CHROMIUM, 2013-10-16 20:34:40]

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:457:
"video/mp4", aac_codec(), kPrefixedClearKey));
On 2013/10/16 17:31:31, ddorwin wrote:
> should this one be avc3?
yep. Done.

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:459:
EXPECT_PROPRIETARY(IsSupportedKeySystemWithMediaMimeType(
On 2013/10/16 17:31:31, ddorwin wrote:
> indentation and extra blank line

Done.

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:492:
"audio/mp4", avc1_and_aac_codecs(), kPrefixedClearKey));
On 2013/10/16 17:31:31, ddorwin wrote:
> add here for consistency with ECK.

Done.

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:816:
EXPECT_WVAVC1AAC(IsSupportedKeySystemWithMediaMimeType(
On 2013/10/16 17:31:31, ddorwin wrote:
> add avc3_codec?

Done.

https://codereview.chromium.org/27374002/diff/36001/chrome/browser/media/encr...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:865:
"audio/mp4", avc1_and_aac_codecs(), kWidevineAlpha));
On 2013/10/16 17:31:31, ddorwin wrote:
> add here for consistency with ECK.

Done.

[commit-bot: I haz the power, 2013-10-16 20:35:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/43001

[commit-bot: I haz the power, 2013-10-16 21:57:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/43001

[commit-bot: I haz the power, 2013-10-17 01:55:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/43001

[commit-bot: I haz the power, 2013-10-17 12:07:08]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-17 15:45:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/43001

[commit-bot: I haz the power, 2013-10-18 01:42:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/27374002/43001

[commit-bot: I haz the power, 2013-10-18 10:30:00]

Change committed as 229347

[tonyg, 2013-10-18 20:53:31]

On 2013/10/18 10:30:00, I haz the power (commit-bot) wrote:
> Change committed as 229347

I think this change might have conflicted with a new unused constant warning
(https://codereview.chromium.org/28163003/) to break the perf bots.

http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/51227...

/b/build/slave/chromium-rel-mac-builder/build/src/chrome/renderer/media/chrome_key_systems.cc:39:12:
error: unused variable 'kAvc1Avc3' [-Werror,-Wunused-const-variable,24]
 const char kAvc1Avc3[] = "avc1,avc3";
            ^
1 error generated.


** BUILD FAILED **