mac: Fix build with ffmpeg_branding=Chrome proprietary_codecs=1.

mac: Fix build with ffmpeg_branding=Chrome proprietary_codecs=1.

BUG=307668
R=acolwell@chromium.org
TBR=acolwell

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229476

[Nico, 2013-10-18 21:39:45]

tbr'ing to fix the mac perf builder

[acolwell GONE FROM CHROMIUM, 2013-10-18 21:41:18]

lgtm % nit

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] =
"avc1,avc3";
nit: How about just moving this into the #ifdef below w/ the other Widevine
specific constants and enums.

[Nico, 2013-10-18 21:43:12]

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] =
"avc1,avc3";
On 2013/10/18 21:41:18, acolwell wrote:
> nit: How about just moving this into the #ifdef below w/ the other Widevine
> specific constants and enums.

Done.

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] =
"avc1,avc3";
On 2013/10/18 21:41:18, acolwell wrote:
> nit: How about just moving this into the #ifdef below w/ the other Widevine
> specific constants and enums.

Does that change much? Down there it'd have to be wrapped in #if
defined(USE_PROPRIETARY_CODECS), right? Here's at least next to the other const
char[]s.

[acolwell GONE FROM CHROMIUM, 2013-10-18 21:45:54]

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_...
chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] =
"avc1,avc3";
On 2013/10/18 21:43:12, Nico wrote:
> On 2013/10/18 21:41:18, acolwell wrote:
> > nit: How about just moving this into the #ifdef below w/ the other Widevine
> > specific constants and enums.
> 
> Does that change much? Down there it'd have to be wrapped in #if
> defined(USE_PROPRIETARY_CODECS), right? Here's at least next to the other
const
> char[]s.
Oh right. How about just inlining this since it isn't actually being reused
anywhere? Otherwise I'm fine with this as is.

[Nico, 2013-10-18 21:46:47]

On Fri, Oct 18, 2013 at 2:43 PM, <thakis@chromium.org> wrote:

>
> https://codereview.chromium.**org/28053006/diff/1/chrome/**
>
renderer/media/chrome_key_**systems.cc<https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc>
> File chrome/renderer/media/chrome_**key_systems.cc (right):
>
> https://codereview.chromium.**org/28053006/diff/1/chrome/**
>
renderer/media/chrome_key_**systems.cc#newcode40<https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode40>
> chrome/renderer/media/chrome_**key_systems.cc:40: const char kAvc1Avc3[] =
> "avc1,avc3";
> On 2013/10/18 21:41:18, acolwell wrote:
>
>> nit: How about just moving this into the #ifdef below w/ the other
>>
> Widevine
>
>> specific constants and enums.
>>
>
> Done.


(actually not done. I clicked "done" but when I then went to do this, I
noticed that it's not any better and then wrote the below comment)


>
>
> https://codereview.chromium.**org/28053006/diff/1/chrome/**
>
renderer/media/chrome_key_**systems.cc#newcode40<https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode40>
> chrome/renderer/media/chrome_**key_systems.cc:40: const char kAvc1Avc3[] =
> "avc1,avc3";
> On 2013/10/18 21:41:18, acolwell wrote:
>
>> nit: How about just moving this into the #ifdef below w/ the other
>>
> Widevine
>
>> specific constants and enums.
>>
>
> Does that change much? Down there it'd have to be wrapped in #if
> defined(USE_PROPRIETARY_**CODECS), right? Here's at least next to the
> other const char[]s.
>
>
https://codereview.chromium.**org/28053006/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-10-18 21:47:52]

Since it's just a nit I'll go and land this as is as that's a bit faster and it
heals a bot (hopefully). You can then change it to your heart's content (I'll
lgtm an "remove variable" patch immediately for example)

[Nico, 2013-10-18 21:49:38]

Committed patchset #1 manually as r229476 (presubmit successful).