Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 28053006: mac: Fix build with ffmpeg_branding=Chrome proprietary_codecs=1. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

mac: Fix build with ffmpeg_branding=Chrome proprietary_codecs=1. BUG=307668 R=acolwell@chromium.org TBR=acolwell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229476

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +2 lines, -0 lines 4 comments Download

Messages

Total messages: 8 (0 generated)
Nico
7 years, 2 months ago (2013-10-18 21:28:20 UTC) #1
Nico
tbr'ing to fix the mac perf builder
7 years, 2 months ago (2013-10-18 21:39:45 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm % nit https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc File chrome/renderer/media/chrome_key_systems.cc (right): https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode40 chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] = "avc1,avc3"; nit: ...
7 years, 2 months ago (2013-10-18 21:41:18 UTC) #3
Nico
https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc File chrome/renderer/media/chrome_key_systems.cc (right): https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode40 chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] = "avc1,avc3"; On 2013/10/18 21:41:18, acolwell ...
7 years, 2 months ago (2013-10-18 21:43:12 UTC) #4
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc File chrome/renderer/media/chrome_key_systems.cc (right): https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode40 chrome/renderer/media/chrome_key_systems.cc:40: const char kAvc1Avc3[] = "avc1,avc3"; On 2013/10/18 21:43:12, Nico ...
7 years, 2 months ago (2013-10-18 21:45:54 UTC) #5
Nico
On Fri, Oct 18, 2013 at 2:43 PM, <thakis@chromium.org> wrote: > > https://codereview.chromium.**org/28053006/diff/1/chrome/** > renderer/media/chrome_key_**systems.cc<https://codereview.chromium.org/28053006/diff/1/chrome/renderer/media/chrome_key_systems.cc> ...
7 years, 2 months ago (2013-10-18 21:46:47 UTC) #6
Nico
Since it's just a nit I'll go and land this as is as that's a ...
7 years, 2 months ago (2013-10-18 21:47:52 UTC) #7
Nico
7 years, 2 months ago (2013-10-18 21:49:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r229476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698