Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2816263003: Move spelling marker related functions from WebView to WebLocalFrame (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, groby+spellwatch_chromium.org, kinuko+watch, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move spelling marker related functions from WebView to WebLocalFrame Given that spelling markers are managed inside each frame independently, this patch moves the related functions from WebView to WebLocalFrame for better architecture. BUG=638356 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2816263003 Cr-Commit-Position: refs/heads/master@{#465030} Committed: https://chromium.googlesource.com/chromium/src/+/45c072e012350840ad94390e71dd25b2329a3c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -47 lines) Patch
M components/spellcheck/renderer/spellcheck.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-04-17 00:57:04 UTC) #11
tkent
lgtm
3 years, 8 months ago (2017-04-17 00:58:41 UTC) #12
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-17 13:35:18 UTC) #13
Xiaocheng
Thanks for reviewing!
3 years, 8 months ago (2017-04-17 20:08:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816263003/1
3 years, 8 months ago (2017-04-17 20:09:32 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 21:45:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45c072e012350840ad94390e71dd...

Powered by Google App Engine
This is Rietveld 408576698