Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2816263003: Move spelling marker related functions from WebView to WebLocalFrame (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 16ac66b81d9ca2ab9b1ce356f0d49aae56f04ae5..af54f9e9ec198925a30206291bdbc2d6b855caeb 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -45,7 +45,6 @@
#include "core/editing/FrameSelection.h"
#include "core/editing/InputMethodController.h"
#include "core/editing/iterators/TextIterator.h"
-#include "core/editing/markers/DocumentMarkerController.h"
#include "core/editing/serializers/HTMLInterchange.h"
#include "core/editing/serializers/Serialization.h"
#include "core/events/KeyboardEvent.h"
@@ -3423,32 +3422,6 @@ HitTestResult WebViewImpl::CoreHitTestResultAt(
return HitTestResultForRootFramePos(point_in_root_frame);
}
-void WebViewImpl::SpellingMarkerOffsetsForTest(WebVector<unsigned>* offsets) {
- Vector<unsigned> result;
- for (Frame* frame = page_->MainFrame(); frame;
- frame = frame->Tree().TraverseNext()) {
- if (!frame->IsLocalFrame())
- continue;
- const DocumentMarkerVector& document_markers =
- ToLocalFrame(frame)->GetDocument()->Markers().Markers();
- for (size_t i = 0; i < document_markers.size(); ++i)
- result.push_back(document_markers[i]->StartOffset());
- }
- offsets->Assign(result);
-}
-
-void WebViewImpl::RemoveSpellingMarkersUnderWords(
- const WebVector<WebString>& words) {
- Vector<String> converted_words;
- converted_words.Append(words.Data(), words.size());
-
- for (Frame* frame = page_->MainFrame(); frame;
- frame = frame->Tree().TraverseNext()) {
- if (frame->IsLocalFrame())
- ToLocalFrame(frame)->RemoveSpellingMarkersUnderWords(converted_words);
- }
-}
-
void WebViewImpl::SendResizeEventAndRepaint() {
// FIXME: This is wrong. The FrameView is responsible sending a resizeEvent
// as part of layout. Layout is also responsible for sending invalidations
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698