Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2816243004: Adjust visual overflow rect for rounded/shifted ascent/descent (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, krit, szager+layoutwatch_chromium.org, drott+blinkwatch_chromium.org, pdr+graphicswatchlist_chromium.org, zoltan1, blink-reviews-platform-graphics_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, fmalita+watch_chromium.org, dshwang, Rik, Justin Novosad, jchaffraix+rendering, mac-reviews_chromium.org, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Adjust visual overflow rect for rounded/shifted ascent/descent For now we round and/or shift ascent and descent to integers in some cases, and we may layout using ascent/descent smaller than the original, causing that painted text at the laid-out position may overflow the visual overflow calculated based on layout geometries. Now record the loss in FontMetrics and adjust visual overflow rect to cover the overflows. BUG=706298 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2803483002 Cr-Original-Commit-Position: refs/heads/master@{#464689} Review-Url: https://codereview.chromium.org/2816243004 Cr-Commit-Position: refs/branch-heads/3071@{#5} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/40094f47127ab282c4eef8f62bfdd2b92a31cbb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2080 lines, -2723 lines) Patch
A + third_party/WebKit/LayoutTests/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/change-text-content-and-background-color-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/float-overflow-expected.txt View 1 chunk +0 lines, -973 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/float-overflow-right-expected.txt View 1 chunk +0 lines, -973 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/multicol-repaint-expected.txt View 1 chunk +0 lines, -74 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/textarea-caret-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/float-overflow-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/float-overflow-right-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/control-clip-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/control-clip-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/control-clip-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/control-clip-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/control-clip-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/float-overflow-expected.txt View 1 chunk +140 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/float-overflow-right-expected.txt View 1 chunk +140 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-reflow-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-vertical-lr-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-vertical-rl-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-as-paint-container-expected.txt View 1 chunk +108 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-abspos-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-abspos-in-relpos-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-block-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-inline-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-text-expected.txt View 3 chunks +9 lines, -26 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/push-block-with-first-line-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/ruby-flipped-blocks-expected.txt View 2 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-in-relative-positioned-inline-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +7 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/vertical-rl-as-paint-container-expected.txt View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/control-clip-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/float-overflow-expected.txt View 1 chunk +84 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/float-overflow-right-expected.txt View 1 chunk +84 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-outline-repaint-2-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-reflow-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-vertical-lr-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-vertical-rl-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-as-paint-container-expected.txt View 1 chunk +108 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-repaint-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-abspos-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-abspos-in-relpos-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-block-expected.txt View 2 chunks +12 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-inline-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-text-expected.txt View 3 chunks +9 lines, -26 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/push-block-with-first-line-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/ruby-flipped-blocks-expected.txt View 2 chunks +33 lines, -28 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/text-in-relative-positioned-inline-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +7 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/vertical-rl-as-paint-container-expected.txt View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/control-clip-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidation-after-opacity-change-subtree-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/textarea-caret-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/box-inline-resize-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/change-text-content-and-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/control-clip-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/float-overflow-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/float-overflow-right-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/invalidation-after-opacity-change-subtree-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/multicol-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 6 chunks +8 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 3 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp View 3 chunks +34 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816243004/1
3 years, 8 months ago (2017-04-14 23:41:57 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 23:51:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40094f47127ab282c4eef8f62bfd...

Powered by Google App Engine
This is Rietveld 408576698