Roll buildtools d307444854..88811f48a6

Roll buildtools d307444854..88811f48a6

  In order to roll GN c3cb4770dc..71aff04f37 (r456551:r464797) and pick up
  the following changes:

  eacc100 Remove base::StackString.
  ac2df0a Moved/renamed EscapeString from visual_studio_writer to XmlEscape in xml_element_writer.
  a5676c6 Reland of Change base::Value::ListStorage to std::vector<base::Value>
  df600cd Revert of Change base::Value::ListStorage to std::vector<base::Value> (patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
  ebab0de Change base::Value::ListStorage to std::vector<base::Value>
  7dbbea4 "Escape" certain characters
  e067999 Remove base::Value::CreateNullValue
  f7c8a0d Explicitly specify whether to emit frame pointers by default.
  707f1a6 Fix comments in GN standalone docs.
  f6b258c GN: Re-generate reference.md
  f34c3e0 memory-infra: Add peak-detector skeleton.
  9a9a8c2 memory-infra: refactoring to extract MemoryDumpProviderInfo class
  589d05e Add missing header files to GN files
  b62c0d4 Get gn analyze to respect changes to vs_toolchain.py
  6112547 [iOS] Add application target as dependency of xctest module target.
  b17ee3d Add comment on TBR'ing GN bootstrap changes.
  e2b71b9 Fix GN bootstrap
  823f2a2 GN: Trim newlines in markdown help blocks
  64b5d69 mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002
  f78cc27 Enable noexcept on Windows, use for a few move constructors.
  12c27f4 Revert of Enable noexcept on Windows, use for a few move constructors. (patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
  76aac97 Enable noexcept on Windows, use for a few move constructors.
  c5a7643 Fix GN bootstrap
  20f4fea Improve the markdown output for GN's reference documentation.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2816243002
Cr-Commit-Position: refs/heads/master@{#464824}
Committed: https://chromium.googlesource.com/chromium/src/+/b257d04c186eb00cd7d17b2c30c95df6702a4ff3

[Dirk Pranke, 2017-04-14 22:02:22]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2017-04-14 22:02:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-14 22:05:10]

Description was changed from

==========
Roll buildtools d307444854..88811f48a6

  In order to roll GN c3cb4770dc..71aff04f37 (r456551:r464797) and pick up
  the following changes:

  eacc100 Remove base::StackString.
  ac2df0a Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.
  a5676c6 Reland of Change base::Value::ListStorage to std::vector<base::Value>
  df600cd Revert of Change base::Value::ListStorage to std::vector<base::Value>
(patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
  ebab0de Change base::Value::ListStorage to std::vector<base::Value>
  7dbbea4 "Escape" certain characters
  e067999 Remove base::Value::CreateNullValue
  f7c8a0d Explicitly specify whether to emit frame pointers by default.
  707f1a6 Fix comments in GN standalone docs.
  f6b258c GN: Re-generate reference.md
  f34c3e0 memory-infra: Add peak-detector skeleton.
  9a9a8c2 memory-infra: refactoring to extract MemoryDumpProviderInfo class
  589d05e Add missing header files to GN files
  b62c0d4 Get gn analyze to respect changes to vs_toolchain.py
  6112547 [iOS] Add application target as dependency of xctest module target.
  b17ee3d Add comment on TBR'ing GN bootstrap changes.
  e2b71b9 Fix GN bootstrap
  823f2a2 GN: Trim newlines in markdown help blocks
  64b5d69 mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002
  f78cc27 Enable noexcept on Windows, use for a few move constructors.
  12c27f4 Revert of Enable noexcept on Windows, use for a few move constructors.
(patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
  76aac97 Enable noexcept on Windows, use for a few move constructors.
  c5a7643 Fix GN bootstrap
  20f4fea Improve the markdown output for GN's reference documentation.

TBR=brettw@chromium.org
==========

to

==========
Roll buildtools d307444854..88811f48a6

  In order to roll GN c3cb4770dc..71aff04f37 (r456551:r464797) and pick up
  the following changes:

  eacc100 Remove base::StackString.
  ac2df0a Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.
  a5676c6 Reland of Change base::Value::ListStorage to std::vector<base::Value>
  df600cd Revert of Change base::Value::ListStorage to std::vector<base::Value>
(patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
  ebab0de Change base::Value::ListStorage to std::vector<base::Value>
  7dbbea4 "Escape" certain characters
  e067999 Remove base::Value::CreateNullValue
  f7c8a0d Explicitly specify whether to emit frame pointers by default.
  707f1a6 Fix comments in GN standalone docs.
  f6b258c GN: Re-generate reference.md
  f34c3e0 memory-infra: Add peak-detector skeleton.
  9a9a8c2 memory-infra: refactoring to extract MemoryDumpProviderInfo class
  589d05e Add missing header files to GN files
  b62c0d4 Get gn analyze to respect changes to vs_toolchain.py
  6112547 [iOS] Add application target as dependency of xctest module target.
  b17ee3d Add comment on TBR'ing GN bootstrap changes.
  e2b71b9 Fix GN bootstrap
  823f2a2 GN: Trim newlines in markdown help blocks
  64b5d69 mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002
  f78cc27 Enable noexcept on Windows, use for a few move constructors.
  12c27f4 Revert of Enable noexcept on Windows, use for a few move constructors.
(patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
  76aac97 Enable noexcept on Windows, use for a few move constructors.
  c5a7643 Fix GN bootstrap
  20f4fea Improve the markdown output for GN's reference documentation.

TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2017-04-14 23:29:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492207342271640, "parent_rev":
"9efcad1ba88ddc3e0161ba50fdb3a7c7dbe61932", "commit_rev":
"b257d04c186eb00cd7d17b2c30c95df6702a4ff3"}

[commit-bot: I haz the power, 2017-04-14 23:30:55]

Description was changed from

==========
Roll buildtools d307444854..88811f48a6

  In order to roll GN c3cb4770dc..71aff04f37 (r456551:r464797) and pick up
  the following changes:

  eacc100 Remove base::StackString.
  ac2df0a Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.
  a5676c6 Reland of Change base::Value::ListStorage to std::vector<base::Value>
  df600cd Revert of Change base::Value::ListStorage to std::vector<base::Value>
(patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
  ebab0de Change base::Value::ListStorage to std::vector<base::Value>
  7dbbea4 "Escape" certain characters
  e067999 Remove base::Value::CreateNullValue
  f7c8a0d Explicitly specify whether to emit frame pointers by default.
  707f1a6 Fix comments in GN standalone docs.
  f6b258c GN: Re-generate reference.md
  f34c3e0 memory-infra: Add peak-detector skeleton.
  9a9a8c2 memory-infra: refactoring to extract MemoryDumpProviderInfo class
  589d05e Add missing header files to GN files
  b62c0d4 Get gn analyze to respect changes to vs_toolchain.py
  6112547 [iOS] Add application target as dependency of xctest module target.
  b17ee3d Add comment on TBR'ing GN bootstrap changes.
  e2b71b9 Fix GN bootstrap
  823f2a2 GN: Trim newlines in markdown help blocks
  64b5d69 mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002
  f78cc27 Enable noexcept on Windows, use for a few move constructors.
  12c27f4 Revert of Enable noexcept on Windows, use for a few move constructors.
(patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
  76aac97 Enable noexcept on Windows, use for a few move constructors.
  c5a7643 Fix GN bootstrap
  20f4fea Improve the markdown output for GN's reference documentation.

TBR=brettw@chromium.org
==========

to

==========
Roll buildtools d307444854..88811f48a6

  In order to roll GN c3cb4770dc..71aff04f37 (r456551:r464797) and pick up
  the following changes:

  eacc100 Remove base::StackString.
  ac2df0a Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.
  a5676c6 Reland of Change base::Value::ListStorage to std::vector<base::Value>
  df600cd Revert of Change base::Value::ListStorage to std::vector<base::Value>
(patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
  ebab0de Change base::Value::ListStorage to std::vector<base::Value>
  7dbbea4 "Escape" certain characters
  e067999 Remove base::Value::CreateNullValue
  f7c8a0d Explicitly specify whether to emit frame pointers by default.
  707f1a6 Fix comments in GN standalone docs.
  f6b258c GN: Re-generate reference.md
  f34c3e0 memory-infra: Add peak-detector skeleton.
  9a9a8c2 memory-infra: refactoring to extract MemoryDumpProviderInfo class
  589d05e Add missing header files to GN files
  b62c0d4 Get gn analyze to respect changes to vs_toolchain.py
  6112547 [iOS] Add application target as dependency of xctest module target.
  b17ee3d Add comment on TBR'ing GN bootstrap changes.
  e2b71b9 Fix GN bootstrap
  823f2a2 GN: Trim newlines in markdown help blocks
  64b5d69 mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002
  f78cc27 Enable noexcept on Windows, use for a few move constructors.
  12c27f4 Revert of Enable noexcept on Windows, use for a few move constructors.
(patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
  76aac97 Enable noexcept on Windows, use for a few move constructors.
  c5a7643 Fix GN bootstrap
  20f4fea Improve the markdown output for GN's reference documentation.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2816243002
Cr-Commit-Position: refs/heads/master@{#464824}
Committed:
https://chromium.googlesource.com/chromium/src/+/b257d04c186eb00cd7d17b2c30c9...
==========

[commit-bot: I haz the power, 2017-04-14 23:30:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b257d04c186eb00cd7d17b2c30c9...

[brucedawson, 2017-04-15 00:00:14]

On 2017/04/14 23:30:56, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/b257d04c186eb00cd7d17b2c30c9...

The "gn analyze" part of the change works like a charm. I can now run "git cl
try" with a single character change (s/2015/2017/) and that is sufficient to
trigger a full rebuild with the 2017 compiler. The gn analyze output is:

analyze input:
{
  "additional_compile_targets": [], 
  "files": [
    "build/vs_toolchain.py"
  ], 
  "test_targets": [
    "accessibility_unittests", 
    "accessibility_unittests_run", 
    "app_shell_unittests", 
...

and the new toolchain path is enough to trigger full recompiles. No more
landmines!