Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2816203002: Remove usage of Tab's |url| property for BookmarkInteractionController. (Closed)

Created:
3 years, 8 months ago by kkhorimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of Tab's |url| property for BookmarkInteractionController. BUG=546208 Review-Url: https://codereview.chromium.org/2816203002 Cr-Commit-Position: refs/heads/master@{#465381} Committed: https://chromium.googlesource.com/chromium/src/+/fc41f520d4df2e21259ce2cf9efb6f48338ca2a2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm View 2 chunks +4 lines, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
kkhorimoto
This CL updates to use lastCommittedURL, as this would match the content that is seen ...
3 years, 8 months ago (2017-04-14 18:41:24 UTC) #4
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2816203002/diff/1/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm File ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm (right): https://codereview.chromium.org/2816203002/diff/1/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm#newcode154 ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:154: tab.lastCommittedURL); I checked that Desktop adds bookmark for ...
3 years, 8 months ago (2017-04-14 21:06:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816203002/1
3 years, 8 months ago (2017-04-18 21:21:30 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:34:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc41f520d4df2e21259ce2cf9efb...

Powered by Google App Engine
This is Rietveld 408576698