Remove usage of Tab's |url| property for BookmarkInteractionController.

Remove usage of Tab's |url| property for BookmarkInteractionController.

BUG=546208
Review-Url: https://codereview.chromium.org/2816203002
Cr-Commit-Position: refs/heads/master@{#465381}
Committed: https://chromium.googlesource.com/chromium/src/+/fc41f520d4df2e21259ce2cf9efb6f48338ca2a2

[kkhorimoto, 2017-04-14 18:37:44]

Description was changed from

==========
Eliminate |url| usage for BookmarkInteractionController.

BUG=546208
==========

to

==========
Remove |url| usage for BookmarkInteractionController.

BUG=546208
==========

[kkhorimoto, 2017-04-14 18:38:34]

Description was changed from

==========
Remove |url| usage for BookmarkInteractionController.

BUG=546208
==========

to

==========
Remove usage of Tab's |url| property for BookmarkInteractionController.

BUG=546208
==========

[kkhorimoto, 2017-04-14 18:41:23]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-04-14 18:41:24]

This CL updates to use lastCommittedURL, as this would match the content that is
seen in the web view.  However, if we used visible URL, there shouldn't be any
effects on security, as going to the bookmark would load the pending URL instead
of a possibly malicious page that's attempting to spoof.

[Eugene But (OOO till 7-30), 2017-04-14 21:06:24]

lgtm

https://codereview.chromium.org/2816203002/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm (right):

https://codereview.chromium.org/2816203002/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:154:
tab.lastCommittedURL);
I checked that Desktop adds bookmark for lastCommittedURL.

[kkhorimoto, 2017-04-18 21:20:49]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:21:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:34:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492550449648100, "parent_rev":
"6e1d09bf3327be410524f9d594c7c218b5845de3", "commit_rev":
"fc41f520d4df2e21259ce2cf9efb6f48338ca2a2"}

[commit-bot: I haz the power, 2017-04-18 21:34:38]

Description was changed from

==========
Remove usage of Tab's |url| property for BookmarkInteractionController.

BUG=546208
==========

to

==========
Remove usage of Tab's |url| property for BookmarkInteractionController.

BUG=546208

Review-Url: https://codereview.chromium.org/2816203002
Cr-Commit-Position: refs/heads/master@{#465381}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc41f520d4df2e21259ce2cf9efb...
==========

[commit-bot: I haz the power, 2017-04-18 21:34:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc41f520d4df2e21259ce2cf9efb...