bindings: Place bool flags in a batch in IDL dictionary

bindings: Place bool flags in a batch in IDL dictionary

Before this CL the code generator put bool flags next to member
variables. This caused unwanted paddings (e.g. seven bytes of padding
after a double member). Put bool flags in a batch to reduce paddings.

BUG=711101
Review-Url: https://codereview.chromium.org/2816143003
Cr-Commit-Position: refs/heads/master@{#464702}
Committed: https://chromium.googlesource.com/chromium/src/+/b9b0560ef757a95e871f72263e8932559a0e23d0

[bashi, 2017-04-14 01:07:13]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 01:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-04-14 02:27:45]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, peria@chromium.org, yukishiino@chromium.org

[bashi, 2017-04-14 02:27:45]

PTAL

sizeof(ConstrainDoubleRange) 72 -> 56 on my Linux x86_64.

[commit-bot: I haz the power, 2017-04-14 02:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:36:05]

Dry run: This issue passed the CQ dry run.

[peria, 2017-04-14 03:20:04]

LGTM

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
(right):

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl:42: {% for
member in members %}
nit: would you put an empty line between two {% for %} loops?

[bashi, 2017-04-14 03:22:47]

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
(right):

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl:42: {% for
member in members %}
On 2017/04/14 03:20:04, peria wrote:
> nit: would you put an empty line between two {% for %} loops?

Hmm, actually I did that but reverted because it produced an empty line when
there is no bool flag.

[peria, 2017-04-14 03:44:49]

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
(right):

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl:42: {% for
member in members %}
On 2017/04/14 03:22:47, bashi wrote:
> On 2017/04/14 03:20:04, peria wrote:
> > nit: would you put an empty line between two {% for %} loops?
> 
> Hmm, actually I did that but reverted because it produced an empty line when
> there is no bool flag.

IMO, such empty lines should be removed in the filter
format_blink_cpp_source_code, and having an empty line
just below "private:" is acceptable.

[bashi, 2017-04-14 03:53:59]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 03:54:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-04-14 03:55:28]

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
(right):

https://codereview.chromium.org/2816143003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl:42: {% for
member in members %}
On 2017/04/14 03:44:49, peria wrote:
> On 2017/04/14 03:22:47, bashi wrote:
> > On 2017/04/14 03:20:04, peria wrote:
> > > nit: would you put an empty line between two {% for %} loops?
> > 
> > Hmm, actually I did that but reverted because it produced an empty line when
> > there is no bool flag.
> 
> IMO, such empty lines should be removed in the filter
> format_blink_cpp_source_code, and having an empty line
> just below "private:" is acceptable.

I'd prefer not having an empty line but either is fine with me. Done.

[commit-bot: I haz the power, 2017-04-14 05:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 05:21:45]

Dry run: This issue passed the CQ dry run.

[Yuki, 2017-04-14 06:38:58]

LGTM.

[bashi, 2017-04-14 08:06:56]

The CQ bit was checked by bashi@chromium.org

[bashi, 2017-04-14 08:06:56]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org
Link to the patchset: https://codereview.chromium.org/2816143003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-04-14 08:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 08:11:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492157216460650,
"parent_rev": "e594588348ea08e4cdc15dc587efa5645db5023e", "commit_rev":
"b9b0560ef757a95e871f72263e8932559a0e23d0"}

[commit-bot: I haz the power, 2017-04-14 08:12:19]

Description was changed from

==========
bindings: Place bool flags in a batch in IDL dictionary

Before this CL the code generator put bool flags next to member
variables. This caused unwanted paddings (e.g. seven bytes of padding
after a double member). Put bool flags in a batch to reduce paddings.

BUG=711101
==========

to

==========
bindings: Place bool flags in a batch in IDL dictionary

Before this CL the code generator put bool flags next to member
variables. This caused unwanted paddings (e.g. seven bytes of padding
after a double member). Put bool flags in a batch to reduce paddings.

BUG=711101

Review-Url: https://codereview.chromium.org/2816143003
Cr-Commit-Position: refs/heads/master@{#464702}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9b0560ef757a95e871f72263e89...
==========

[commit-bot: I haz the power, 2017-04-14 08:12:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9b0560ef757a95e871f72263e89...

[haraken, 2017-04-14 18:52:58]

LGTM