Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

Issue 2816143003: bindings: Place bool flags in a batch in IDL dictionary (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #ifndef {{cpp_class}}_h 4 #ifndef {{cpp_class}}_h
5 #define {{cpp_class}}_h 5 #define {{cpp_class}}_h
6 6
7 {% for filename in header_includes %} 7 {% for filename in header_includes %}
8 #include "{{filename}}" 8 #include "{{filename}}"
9 {% endfor %} 9 {% endfor %}
10 10
(...skipping 18 matching lines...) Expand all
29 void {{member.setter_name}}({{member.rvalue_cpp_type}}); 29 void {{member.setter_name}}({{member.rvalue_cpp_type}});
30 {% if member.null_setter_name %} 30 {% if member.null_setter_name %}
31 void {{member.null_setter_name}}(); 31 void {{member.null_setter_name}}();
32 {% endif %} 32 {% endif %}
33 33
34 {% endfor %} 34 {% endfor %}
35 v8::Local<v8::Value> ToV8Impl(v8::Local<v8::Object>, v8::Isolate*) const overr ide; 35 v8::Local<v8::Value> ToV8Impl(v8::Local<v8::Object>, v8::Isolate*) const overr ide;
36 DECLARE_VIRTUAL_TRACE(); 36 DECLARE_VIRTUAL_TRACE();
37 37
38 private: 38 private:
39 {% for member in members if member.nullable_indicator_name %}
40 bool {{member.nullable_indicator_name}} = false;
41 {% endfor %}
39 {% for member in members %} 42 {% for member in members %}
peria 2017/04/14 03:20:04 nit: would you put an empty line between two {% fo
bashi 2017/04/14 03:22:47 Hmm, actually I did that but reverted because it p
peria 2017/04/14 03:44:49 IMO, such empty lines should be removed in the fil
bashi 2017/04/14 03:55:28 I'd prefer not having an empty line but either is
40 {% if member.nullable_indicator_name %}
41 bool {{member.nullable_indicator_name}} = false;
42 {% endif %}
43 {{member.member_cpp_type}} m_{{member.cpp_name}}; 43 {{member.member_cpp_type}} m_{{member.cpp_name}};
44 {% endfor %} 44 {% endfor %}
45 45
46 friend class V8{{cpp_class}}; 46 friend class V8{{cpp_class}};
47 }; 47 };
48 48
49 } // namespace blink 49 } // namespace blink
50 50
51 #endif // {{cpp_class}}_h 51 #endif // {{cpp_class}}_h
52 52
53 {% endfilter %}{# format_blink_cpp_source_code #} 53 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698