config: fix config.Dict with no value type

config: fix config.Dict with no value type

Dict.set_value crashes in value_type is None (default). Fix that.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2816083003
Committed: https://github.com/luci/recipes-py/commit/23230785ddaec6e199d3ede6d496131ec178c183

[nodir, 2017-04-13 21:35:58]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2017-04-13 21:36:16]

PTAL

[commit-bot: I haz the power, 2017-04-13 21:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:38:55]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-04-13 21:41:02]

lgtm...

I so want to delete all of this config code >_<.

https://codereview.chromium.org/2816083003/diff/1/recipe_engine/config.py
File recipe_engine/config.py (right):

https://codereview.chromium.org/2816083003/diff/1/recipe_engine/config.py#new...
recipe_engine/config.py:587: assigned to this dictionary.
"If None, the value can be any type."

[nodir, 2017-05-10 19:55:05]

The CQ bit was checked by nodir@chromium.org

[nodir, 2017-05-10 19:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2816083003/#ps20001
(title: "docstring")

[commit-bot: I haz the power, 2017-05-10 19:55:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2017-05-10 19:55:19]

https://codereview.chromium.org/2816083003/diff/1/recipe_engine/config.py
File recipe_engine/config.py (right):

https://codereview.chromium.org/2816083003/diff/1/recipe_engine/config.py#new...
recipe_engine/config.py:587: assigned to this dictionary.
On 2017/04/13 21:41:02, iannucci wrote:
> "If None, the value can be any type."

Done.

[commit-bot: I haz the power, 2017-05-10 19:58:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494446105607460,
"parent_rev": "c93ed98c3c3e6c9be82e88496e55cb1f3dd13372", "commit_rev":
"23230785ddaec6e199d3ede6d496131ec178c183"}

[commit-bot: I haz the power, 2017-05-10 19:58:05]

Description was changed from

==========
config: fix config.Dict with no value type

Dict.set_value crashes in value_type is None (default). Fix that.

R=iannucci@chromium.org
BUG=
==========

to

==========
config: fix config.Dict with no value type

Dict.set_value crashes in value_type is None (default). Fix that.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2816083003
Committed:
https://github.com/luci/recipes-py/commit/23230785ddaec6e199d3ede6d496131ec17...
==========

[commit-bot: I haz the power, 2017-05-10 19:58:06]

Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/23230785ddaec6e199d3ede6d496131ec17...