config: fix config.Dict with no value type

recipe_engine/config.py

 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Recipe Configuration Meta DSL.
 
 This module contains, essentially, a DSL for writing composable configurations.
 You start by defining a schema which describes how your configuration blobs will
 be structured, and what data they can contain. For example:
 
@@ skipping 566 matching lines @@
 
   def __init__(self, item_fn=lambda i: i, jsonish_fn=dict, value_type=None,
                hidden=AutoHide):
     """
     Args:
       item_fn - A function which renders (k, v) pairs to input items for
         jsonish_fn. Defaults to the identity function.
       jsonish_fn - A function which renders a list of outputs of item_fn to a
         JSON-compatiple python datatype. Defaults to dict().
       value_type - A type object used for constraining/validating the values
         assigned to this dictionary.

[iannucci, 2017/04/13 21:41:02]

"If None, the value can be any type."

[nodir, 2017/05/10 19:55:19]

Done.

       hidden - See ConfigBase.
     """
     super(Dict, self).__init__(hidden)
     self.value_type = value_type
     self.item_fn = item_fn
     self.jsonish_fn = jsonish_fn
     self.data = {}
 
   def __getitem__(self, k):
     return self.data.__getitem__(k)
@@ skipping 15 matching lines @@
   def __repr__(self):
     return repr(self.data)
 
   def __str__(self):
     return str(self.data)
 
   def set_val(self, val):
     if isinstance(val, Dict):
       val = val.data
     typeAssert(val, collections.Mapping)
-    for v in val.itervalues():
-      typeAssert(v, self.value_type)
+    if self.value_type:
+      for v in val.itervalues():
+        typeAssert(v, self.value_type)
     self.data = val
 
   def as_jsonish(self, _include_hidden=None):
     return self.jsonish_fn(map(
       self.item_fn, sorted(self.data.iteritems(), key=lambda x: x[0])))
 
   def reset(self):
     self.data.clear()
 
   def complete(self):
@@ skipping 269 matching lines @@
 
   def _is_default(self):
     return self.data is None
 
   def schema_proto(self):
     ret = doc.Doc.Schema()
     ret.enum.values_json.extend(json.dumps(self.jsonish_fn(v))
                                 for v in self.values)
     ret.enum.required = self.required
     return ret