Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2816053002: [TTS] Update testTextTapFollowedByNonTextTap. (Closed)

Created:
3 years, 8 months ago by Donn Denman
Modified:
3 years, 8 months ago
Reviewers:
mdjones
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Update testTextTapFollowedByNonTextTap. This test has been flaky and was disabled, reenbling with a change to call mockTapEmptySpace() on the UI thread. BUG=706663 Review-Url: https://codereview.chromium.org/2816053002 Cr-Commit-Position: refs/heads/master@{#464543} Committed: https://chromium.googlesource.com/chromium/src/+/954690e8953632f30cb944e78340bb8900830566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java View 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Donn Denman
Matt, PTAL I just changed mockTapEmptySpace run on the UI thread as you suggested in ...
3 years, 8 months ago (2017-04-13 20:06:26 UTC) #2
mdjones
lgtm
3 years, 8 months ago (2017-04-13 20:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816053002/1
3 years, 8 months ago (2017-04-13 20:39:55 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 20:59:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/954690e8953632f30cb944e78340...

Powered by Google App Engine
This is Rietveld 408576698