Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

Issue 2816053002: [TTS] Update testTextTapFollowedByNonTextTap. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
index 01021fc80f7bca53f30cad6ce009c1d81176788d..cecd71ac51fde4ce91c1820dae3a06551b7c3d16 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
@@ -4,12 +4,16 @@
package org.chromium.chrome.browser.contextualsearch;
+import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_NON_LOW_END_DEVICE;
+
import android.content.Context;
import android.net.Uri;
+import android.support.test.filters.SmallTest;
import android.widget.LinearLayout;
import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.DisabledTest;
+import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManager;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManagerWrapper;
@@ -204,9 +208,14 @@ public class ContextualSearchTapEventTest extends ChromeActivityTestCaseBase<Chr
* Trigger empty space tap.
*/
private void mockTapEmptySpace() {
- mContextualSearchClient.showUnhandledTapUIIfNeeded(0, 0);
- mContextualSearchClient.onSelectionEvent(
- SelectionEventType.SELECTION_HANDLES_CLEARED, 0, 0);
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ mContextualSearchClient.showUnhandledTapUIIfNeeded(0, 0);
+ mContextualSearchClient.onSelectionEvent(
+ SelectionEventType.SELECTION_HANDLES_CLEARED, 0, 0);
+ }
+ });
}
// --------------------------------------------------------------------------------------------
@@ -246,13 +255,10 @@ public class ContextualSearchTapEventTest extends ChromeActivityTestCaseBase<Chr
/**
* Tests that a Tap gesture followed by tapping empty space closes the panel.
- *
- * Disabled because of flakiness. See crbug.com/706663
*/
- //@SmallTest
- //@Feature({"ContextualSearch"})
- //@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
- @DisabledTest
+ @SmallTest
+ @Feature({"ContextualSearch"})
+ @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
public void testTextTapFollowedByNonTextTap() {
assertTrue(mPanelManager.getRequestPanelShowCount() == 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698