Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: test/inspector/inspector-impl.h

Issue 2816043006: [inspector] avoid cloning of async call chains (Closed)
Patch Set: lines and columns in stack string should be 1-based Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/debugger/set-async-call-stack-depth-expected.txt ('k') | test/inspector/inspector-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/inspector-impl.h
diff --git a/test/inspector/inspector-impl.h b/test/inspector/inspector-impl.h
index 4312de9bbbb01770771858d5dd3741ad80b803e8..5cff979c0ebc2c2c8f3165f25f77142ea3e98a91 100644
--- a/test/inspector/inspector-impl.h
+++ b/test/inspector/inspector-impl.h
@@ -40,6 +40,7 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
void setCurrentTimeMSForTest(double time);
void setMemoryInfoForTest(v8::Local<v8::Value> memory_info);
+ void setLogConsoleApiMessageCalls(bool log);
private:
// V8InspectorClient implementation.
@@ -51,7 +52,12 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
v8::Local<v8::Context>) override;
void runMessageLoopOnPause(int context_group_id) override;
void quitMessageLoopOnPause() override;
-
+ void consoleAPIMessage(int contextGroupId,
+ v8::Isolate::MessageErrorLevel level,
+ const v8_inspector::StringView& message,
+ const v8_inspector::StringView& url,
+ unsigned lineNumber, unsigned columnNumber,
+ v8_inspector::V8StackTrace*) override;
friend class SendMessageToBackendTask;
friend class ConnectTask;
@@ -75,6 +81,7 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
bool current_time_set_for_test_ = false;
double current_time_ = 0.0;
+ bool log_console_api_message_calls_ = false;
DISALLOW_COPY_AND_ASSIGN(InspectorClientImpl);
};
« no previous file with comments | « test/inspector/debugger/set-async-call-stack-depth-expected.txt ('k') | test/inspector/inspector-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698