Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2816023003: Disables testShowJavaScriptAfterNewTabAnimation on tablets. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables testShowJavaScriptAfterNewTabAnimation on tablets. This test is failing after a chromium roll. Temporary disable it for a greener tree. BUG=711291 Review-Url: https://codereview.chromium.org/2816023003 Cr-Commit-Position: refs/heads/master@{#464397} Committed: https://chromium.googlesource.com/chromium/src/+/6ad54113b471bd1e8e82179d23cb55d70b1b2f38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-13 13:41:43 UTC) #2
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-13 13:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816023003/1
3 years, 8 months ago (2017-04-13 13:49:46 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 14:11:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ad54113b471bd1e8e82179d23cb...

Powered by Google App Engine
This is Rietveld 408576698