Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm

Issue 2816023003: Disables testShowJavaScriptAfterNewTabAnimation on tablets. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
diff --git a/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm b/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
index 5e81cc907b90a08b731187ed8af3b423289cceb7..2c7e0f421ca727a8ee935042249deaf85a96733b 100644
--- a/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
+++ b/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
@@ -555,6 +555,11 @@ void TapSuppressDialogsButton() {
@"correctly.");
#endif
+ // TODO(crbug.com/711291): reenable this on tablets.
+ if (IsIPadIdiom()) {
+ EARL_GREY_TEST_DISABLED(@"Disabled for iPad.");
+ }
+
// Load the test page with a link to kOnLoadAlertURL and long tap on the link.
[self loadPageWithLink];
id<GREYMatcher> webViewMatcher =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698