Get Chrome compiling on VS2017 Community edition

Get Chrome compiling on VS2017 Community edition

R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2815873002
Cr-Commit-Position: refs/heads/master@{#464657}
Committed: https://chromium.googlesource.com/chromium/src/+/461b329afc65973c9d25edbae1eff9e0b6979d07

[drbasic, 2017-04-12 14:45:06]

VS++ 2017 Community edition build Chromium fine but vs_toolchain.py can't find
it.

[scottmg, 2017-04-12 17:00:49]

Thanks for the patch.

+Bruce fyi, not sure if you've tried Community at all.

https://codereview.chromium.org/2815873002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2815873002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:153: path = r'C:\Program Files (x86)\Microsoft Visual
Studio\2017\Professional'
Instead of duplicating the check, how about:

for path in (
      os.environ.get('vs2017_install'),
      r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional',
      r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community'):
  if path and os.path.exists(path):
    return path

(or having the paths out in a `paths` variable if that looks nicer).

[brucedawson, 2017-04-12 17:42:13]

I have VS 2017 installed at home but I guess I haven't tried using it to build
Chrome.

When writing git change descriptions it is *crucial* to have a blank line after
the subject - that needs to be fixed before landing.

[drbasic, 2017-04-13 15:20:37]

Description was changed from

==========
Get Chrome compiling on VS2017 Community edition
R=scottmg@chromium.org
BUG=683729
==========

to

==========
Get Chrome compiling on VS2017 Community edition

R=scottmg@chromium.org
BUG=683729
==========

[scottmg, 2017-04-13 16:52:06]

thanks, lgtm

https://codereview.chromium.org/2815873002/diff/40001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2815873002/diff/40001/build/vs_toolchain.py#n...
build/vs_toolchain.py:154: os.environ.get('vs2017_install'),
indent these list elements +4 from here so they don't look like the body of the
'if'.

[drbasic, 2017-04-14 02:01:32]

The CQ bit was checked by drbasic@yandex-team.ru

[drbasic, 2017-04-14 02:01:32]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2815873002/#ps60001
(title: "Fix CC")

[commit-bot: I haz the power, 2017-04-14 02:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 02:13:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492135292327850,
"parent_rev": "d525c83dc997c24ecd618d45c2d932cd2e7feccc", "commit_rev":
"461b329afc65973c9d25edbae1eff9e0b6979d07"}

[commit-bot: I haz the power, 2017-04-14 02:13:59]

Description was changed from

==========
Get Chrome compiling on VS2017 Community edition

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Get Chrome compiling on VS2017 Community edition

R=scottmg@chromium.org
BUG=683729

Review-Url: https://codereview.chromium.org/2815873002
Cr-Commit-Position: refs/heads/master@{#464657}
Committed:
https://chromium.googlesource.com/chromium/src/+/461b329afc65973c9d25edbae1ef...
==========

[commit-bot: I haz the power, 2017-04-14 02:14:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/461b329afc65973c9d25edbae1ef...

[brucedawson, 2017-04-14 16:45:46]

On 2017/04/14 02:14:00, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/461b329afc65973c9d25edbae1ef...

I tested this at home last night and confirmed that community edition 2017 was
broken before but now works. Thanks!