Get Chrome compiling on VS2017 Community edition

build/vs_toolchain.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import json
 import os
 import pipes
 import platform
@@ skipping 132 matching lines @@
   if version_as_year not in year_to_version:
     raise Exception(('Visual Studio version %s (from GYP_MSVS_VERSION)'
                      ' not supported. Supported versions are: %s') % (
                        version_as_year, ', '.join(year_to_version.keys())))
   version = year_to_version[version_as_year]
   if version_as_year == '2017':
     # The VC++ 2017 install location needs to be located using COM instead of
     # the registry. For details see:
     # https://blogs.msdn.microsoft.com/heaths/2016/09/15/changes-to-visual-studio-15-setup/
     # For now we use a hardcoded default with an environment variable override.
     path = r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional'

[scottmg, 2017/04/12 17:00:48]

Instead of duplicating the check, how about:

for path in (
      os.environ.get('vs2017_install'),
      r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional',
      r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community'):
  if path and os.path.exists(path):
    return path

(or having the paths out in a `paths` variable if that looks nicer).

     path = os.environ.get('vs2017_install', path)
     if os.path.exists(path):
       return path
+    # Try MSVS 2017 Community edition.
+    path = r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community'
+    if os.path.exists(path):
+      return path
   else:
     keys = [r'HKLM\Software\Microsoft\VisualStudio\%s' % version,
             r'HKLM\Software\Wow6432Node\Microsoft\VisualStudio\%s' % version]
     for key in keys:
       path = _RegistryGetValue(key, 'InstallDir')
       if not path:
         continue
       path = os.path.normpath(os.path.join(path, '..', '..'))
       return path
 
@@ skipping 244 matching lines @@
       'copy_dlls': CopyDlls,
   }
   if len(sys.argv) < 2 or sys.argv[1] not in commands:
     print >>sys.stderr, 'Expected one of: %s' % ', '.join(commands)
     return 1
   return commands[sys.argv[1]](*sys.argv[2:])
 
 
 if __name__ == '__main__':
   sys.exit(main())