Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2815853002: [arm64] Fix another ubfx corner case. (Closed)

Created:
3 years, 8 months ago by georgia.kouveli
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Fix another ubfx corner case. This issue was fixed in VisitWord64And in 2f8ad11f. Port the fix to VisitWord32And. BUG= Review-Url: https://codereview.chromium.org/2815853002 Cr-Commit-Position: refs/heads/master@{#44636} Committed: https://chromium.googlesource.com/v8/v8/+/57040734d83f2a59bac7940d64a0e69549d0bc64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
georgia.kouveli
3 years, 8 months ago (2017-04-12 13:10:36 UTC) #2
ahaas
LGTM Benedikt, does it look good for you as well? I am not an owner ...
3 years, 8 months ago (2017-04-12 13:12:48 UTC) #3
Benedikt Meurer
lgtm
3 years, 8 months ago (2017-04-13 04:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815853002/1
3 years, 8 months ago (2017-04-13 09:28:03 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 09:51:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/57040734d83f2a59bac7940d64a0e69549d...

Powered by Google App Engine
This is Rietveld 408576698