Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(538)

Issue 2815813002: Remove obsolete bookmarkManagerPrivate.canOpenNewWindows API function (Closed)

Created:
1 year ago by tsergeant
Modified:
1 year ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, tfarina, arv+watch_chromium.org, jlklein+watch-closure_chromium.org, asvitkine+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete bookmarkManagerPrivate.canOpenNewWindows API function The extension API function chrome.bookmarkManagerPrivate.canOpenNewWindows was previously used to disable opening new windows in Windows 8 Metro Mode. Now that mode is removed, the function is essentially a no-op, as it always returns true. Additionally, it is only used by one place in the bookmark manager. This CL removes this obsolete function. BUG=710781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815813002 Cr-Commit-Position: refs/heads/master@{#465140} Committed: https://chromium.googlesource.com/chromium/src/+/5f9e10d18a42268051f35d98c4ed5eb19597fa0c

Patch Set 1 #

Total comments: 2

Messages

Total messages: 17 (11 generated)
tsergeant
This is a pretty straightforward removal -- PTAL, thanks! benwells: c/b/extensions c/c/extensions isherman: histograms.xml extension_function_histogram_value.h ...
1 year ago (2017-04-12 23:27:01 UTC) #9
Ilya Sherman
enum changes lgtm
1 year ago (2017-04-12 23:31:54 UTC) #10
benwells
lgtm https://codereview.chromium.org/2815813002/diff/1/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc File chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc (left): https://codereview.chromium.org/2815813002/diff/1/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc#oldcode800 chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:800: bool can_open_new_windows = true; Seemed like a very ...
1 year ago (2017-04-13 01:09:17 UTC) #11
Dan Beam (no longer on Chrome)
lgtm https://codereview.chromium.org/2815813002/diff/1/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc File chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc (left): https://codereview.chromium.org/2815813002/diff/1/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc#oldcode800 chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:800: bool can_open_new_windows = true; On 2017/04/13 01:09:17, benwells ...
1 year ago (2017-04-18 02:38:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815813002/1
1 year ago (2017-04-18 03:19:29 UTC) #14
commit-bot: I haz the power
1 year ago (2017-04-18 04:43:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f9e10d18a42268051f35d98c4ed...

Powered by Google App Engine
This is Rietveld 408576698