Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 2815813002: Remove obsolete bookmarkManagerPrivate.canOpenNewWindows API function (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
index 94cd27a902a9f3fe73dcd50f1c81eca56125d721..584d9afe48b788f6e5ac3b662edff928dc13fc07 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
@@ -796,12 +796,6 @@ bool BookmarkManagerPrivateUpdateMetaInfoFunction::RunOnReady() {
return true;
}
-bool BookmarkManagerPrivateCanOpenNewWindowsFunction::RunOnReady() {
- bool can_open_new_windows = true;
benwells 2017/04/13 01:09:17 Seemed like a very useful function.
Dan Beam 2017/04/18 02:38:37 reminds me of this lovely function: https://cs.chr
- SetResult(base::MakeUnique<base::Value>(can_open_new_windows));
- return true;
-}
-
bool BookmarkManagerPrivateRemoveTreesFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;

Powered by Google App Engine
This is Rietveld 408576698