predictors: Remove resources marked as unused.

predictors: Remove resources marked as unused.

The PrecacheManifest contains list of subresources no longer used. The predictor
removes such resources from the database after the manifest fetched.

BUG=699115
Review-Url: https://codereview.chromium.org/2815513011
Cr-Commit-Position: refs/heads/master@{#464712}
Committed: https://chromium.googlesource.com/chromium/src/+/09bb93957f9fb4390de8dcca9ca40a6c467f9362

[alexilin, 2017-04-13 15:34:46]

alexilin@chromium.org changed reviewers:
+ lizeb@chromium.org

[alexilin, 2017-04-13 15:34:47]

Hi lizeb, PTAL.

[Benoit L, 2017-04-14 08:26:56]

lgtm

https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor_test_util.cc (right):

https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor_test_util.cc:83: for
(size_t i = 0; i < (bitset.size() + 7) / 8; ++i) {
The most likely representation of vector<bool> is already exactly what you want,
but the bad, bad C++ standard doesn't mandate it (even though it mandates that
vector<bool> is special).
SAD!

[alexilin, 2017-04-14 09:55:09]

The CQ bit was checked by alexilin@chromium.org

[commit-bot: I haz the power, 2017-04-14 09:55:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexilin, 2017-04-14 09:55:22]

https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor_test_util.cc (right):

https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor_test_util.cc:83: for
(size_t i = 0; i < (bitset.size() + 7) / 8; ++i) {
On 2017/04/14 08:26:56, Benoit L wrote:
> The most likely representation of vector<bool> is already exactly what you
want,
> but the bad, bad C++ standard doesn't mandate it (even though it mandates that
> vector<bool> is special).
> SAD!

The world is not perfect. Especially, C++ world.
We will hope that there is no bugs, because we don't test testing code!

[commit-bot: I haz the power, 2017-04-14 10:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492163709921990,
"parent_rev": "0f4782f04c3766c34a6ee1fbc69bd815d724e977", "commit_rev":
"09bb93957f9fb4390de8dcca9ca40a6c467f9362"}

[commit-bot: I haz the power, 2017-04-14 10:40:05]

Description was changed from

==========
predictors: Remove resources marked as unused.

The PrecacheManifest contains list of subresources no longer used. The predictor
removes such resources from the database after the manifest fetched.

BUG=699115
==========

to

==========
predictors: Remove resources marked as unused.

The PrecacheManifest contains list of subresources no longer used. The predictor
removes such resources from the database after the manifest fetched.

BUG=699115

Review-Url: https://codereview.chromium.org/2815513011
Cr-Commit-Position: refs/heads/master@{#464712}
Committed:
https://chromium.googlesource.com/chromium/src/+/09bb93957f9fb4390de8dcca9ca4...
==========

[commit-bot: I haz the power, 2017-04-14 10:40:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09bb93957f9fb4390de8dcca9ca4...