Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2815513011: predictors: Remove resources marked as unused. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Remove resources marked as unused. The PrecacheManifest contains list of subresources no longer used. The predictor removes such resources from the database after the manifest fetched. BUG=699115 Review-Url: https://codereview.chromium.org/2815513011 Cr-Commit-Position: refs/heads/master@{#464712} Committed: https://chromium.googlesource.com/chromium/src/+/09bb93957f9fb4390de8dcca9ca40a6c467f9362

Patch Set 1 #

Patch Set 2 : Remove unused constants. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -2 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 2 chunks +54 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.cc View 1 chunk +19 lines, -0 lines 2 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
alexilin
Hi lizeb, PTAL.
3 years, 8 months ago (2017-04-13 15:34:47 UTC) #2
Benoit L
lgtm https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_test_util.cc File chrome/browser/predictors/resource_prefetch_predictor_test_util.cc (right): https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_test_util.cc#newcode83 chrome/browser/predictors/resource_prefetch_predictor_test_util.cc:83: for (size_t i = 0; i < (bitset.size() ...
3 years, 8 months ago (2017-04-14 08:26:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815513011/20001
3 years, 8 months ago (2017-04-14 09:55:21 UTC) #5
alexilin
https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_test_util.cc File chrome/browser/predictors/resource_prefetch_predictor_test_util.cc (right): https://codereview.chromium.org/2815513011/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_test_util.cc#newcode83 chrome/browser/predictors/resource_prefetch_predictor_test_util.cc:83: for (size_t i = 0; i < (bitset.size() + ...
3 years, 8 months ago (2017-04-14 09:55:22 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 10:40:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09bb93957f9fb4390de8dcca9ca4...

Powered by Google App Engine
This is Rietveld 408576698