Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Issue 2815513011: predictors: Remove resources marked as unused. (Closed)
Patch Set: Remove unused constants. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
index 71ed0e38141286942d9d176447463852e9ac141e..6ba118f3e3c685a210b0876817e5a5b427026201 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
@@ -1181,6 +1181,33 @@ TEST_F(ResourcePrefetchPredictorTest, ManifestUnknownFieldsRemoved) {
predictor_->OnManifestFetched("google.com", manifest_with_unknown_fields);
}
+TEST_F(ResourcePrefetchPredictorTest, ManifestUnusedRemoved) {
+ const std::string& script_url = "http://cdn.google.com/script.js";
+ const std::string& style_url = "http://cdn.google.com/style.css";
+ PrefetchData google = CreatePrefetchData("www.google.com");
+ InitializeResourceData(google.add_resources(), script_url,
+ content::RESOURCE_TYPE_SCRIPT, 10, 0, 1, 2.1,
+ net::MEDIUM, false, false);
+ InitializeResourceData(google.add_resources(), style_url,
+ content::RESOURCE_TYPE_SCRIPT, 10, 0, 1, 2.1,
+ net::MEDIUM, false, false);
+ predictor_->host_table_cache_->insert({google.primary_key(), google});
+
+ precache::PrecacheManifest manifest = CreateManifestData(1);
+ InitializePrecacheResource(manifest.add_resource(), script_url, 0.9);
+ InitializePrecacheResource(manifest.add_resource(), style_url, 0.75);
+ InitializeExperiment(&manifest, internal::kUnusedRemovedExperiment,
+ {true, false});
+
+ // style_url should be removed.
+ google.mutable_resources()->RemoveLast();
+ EXPECT_CALL(*mock_tables_.get(),
+ UpdateResourceData(google, PREFETCH_KEY_TYPE_HOST));
+ EXPECT_CALL(*mock_tables_.get(), UpdateManifestData("google.com", manifest));
+
+ predictor_->OnManifestFetched("google.com", manifest);
+}
+
TEST_F(ResourcePrefetchPredictorTest, DeleteUrls) {
// Add some dummy entries to cache.
predictor_->url_table_cache_->insert(

Powered by Google App Engine
This is Rietveld 408576698