Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2815493002: Move layout tests that use 'js-test.js' to |internals| directory (Closed)

Created:
3 years, 8 months ago by hongchan
Modified:
3 years, 8 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move layout tests that use 'js-test.js' to |internals| directory Certain features in "resources/js-test.js" depends on special hooks from Chromium test runner, and the test using these features cannot be upstreamed. This directory is a collection of such test files. BUG=700049 Review-Url: https://codereview.chromium.org/2815493002 Cr-Commit-Position: refs/heads/master@{#463793} Committed: https://chromium.googlesource.com/chromium/src/+/a844bfcadbed45ee48895081e72d7b9732f0100a

Patch Set 1 #

Patch Set 2 : Path fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-6 lines, -529 lines) Patch
D third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html View 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-lock-threading-race.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-lock-threading-race-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioNode/cycle-connection-gc.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioNode/cycle-connection-gc-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-premature-death.html View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-premature-death-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html View 1 chunk +0 lines, -26 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/internals/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-close.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/audiosource-premature-gc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/audiosummingjunction-crash.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hongchan
PTAL.
3 years, 8 months ago (2017-04-11 15:54:31 UTC) #6
Raymond Toy
lgtm
3 years, 8 months ago (2017-04-11 21:43:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815493002/20001
3 years, 8 months ago (2017-04-11 21:55:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 22:07:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a844bfcadbed45ee48895081e72d...

Powered by Google App Engine
This is Rietveld 408576698