Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2815443002: Fixed launching of multiple instances of download home when tapping notification (Closed)

Created:
3 years, 8 months ago by shaktisahu
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fixed launching of multiple instances of download home when tapping notification Without appropriate launch flags, multiple instances for download home are stacked on top of each other. Using launch mode FLAG_ACTIVITY_SINGLE_TOP prevents that. Also added flag for FLAG_ACTIVITY_MULTIPLE_TASK in order for this to work on multi-window scenario. Verified that this works in Android 6.x and 7.x phones with multi-window. BUG=692020 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2793613002 Cr-Commit-Position: refs/heads/master@{#461970} (cherry picked from commit ff530ff4dd4ad565f73d3fb795c9ed4b6ee69e18) Review-Url: https://codereview.chromium.org/2815443002 Cr-Commit-Position: refs/branch-heads/3029@{#665} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c826550f04db20c096213c55fa344aabf8688de9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
shaktisahu
3 years, 8 months ago (2017-04-10 18:57:51 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 8 months ago (2017-04-11 16:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815443002/1
3 years, 8 months ago (2017-04-11 17:08:47 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-11 17:08:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815443002/1
3 years, 8 months ago (2017-04-11 17:11:07 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:17:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c826550f04db20c096213c55fa34...

Powered by Google App Engine
This is Rietveld 408576698