Fixed launching of multiple instances of download home when tapping notification

Fixed launching of multiple instances of download home when tapping notification

Without appropriate launch flags, multiple instances for download home
are stacked on top of each other. Using launch mode FLAG_ACTIVITY_SINGLE_TOP
prevents that. Also added flag for FLAG_ACTIVITY_MULTIPLE_TASK in order
for this to work on multi-window scenario.

Verified that this works in Android 6.x and 7.x phones with multi-window.

BUG=692020
Review-Url: https://codereview.chromium.org/2793613002
Cr-Commit-Position: refs/heads/master@{#461970}
Committed: https://chromium.googlesource.com/chromium/src/+/ff530ff4dd4ad565f73d3fb795c9ed4b6ee69e18

[shaktisahu, 2017-03-31 18:59:53]

Patchset #1 (id:1) has been deleted

[shaktisahu, 2017-03-31 19:01:50]

Description was changed from

==========
Fixed launching of multiple instances of download home when tapping notification

BUG=692020
==========

to

==========
Fixed launching of multiple instances of download home when tapping notification

BUG=692020
==========

[shaktisahu, 2017-03-31 19:01:50]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[shaktisahu, 2017-03-31 20:21:18]

shaktisahu@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[shaktisahu, 2017-03-31 20:21:19]

PTAL

[gone, 2017-03-31 21:13:11]

How does this fix it?  Neither the bug or the CL description indicates why you
think it addresses the issue or how you tested the behavior.

https://codereview.chromium.org/2793613002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://codereview.chromium.org/2793613002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:132:
intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
Have you tested this in multi-instance mode?  If you do this, you can't open two
Download Home windows from two different ChromeTabbedActivities.

[shaktisahu, 2017-04-01 00:11:41]

Description was changed from

==========
Fixed launching of multiple instances of download home when tapping notification

BUG=692020
==========

to

==========
Fixed launching of multiple instances of download home when tapping notification

Without appropriate launch flags, multiple instances for download home
are stacked on top of each other. Using launch mode FLAG_ACTIVITY_SINGLE_TOP
prevents that. Also added flag for FLAG_ACTIVITY_MULTIPLE_TASK in order
for this to work on multi-window scenario.

Verified that this works in Android 6.x and 7.x phones with multi-window.

BUG=692020
==========

[shaktisahu, 2017-04-01 00:14:29]

https://codereview.chromium.org/2793613002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://codereview.chromium.org/2793613002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:132:
intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
On 2017/03/31 21:13:11, dfalcantara (load balance plz) wrote:
> Have you tested this in multi-instance mode?  If you do this, you can't open
two
> Download Home windows from two different ChromeTabbedActivities.

Added flag FLAG_ACTIVITY_MULTIPLE_TASK. Seems to work correctly for multi-window
now.

[gone, 2017-04-04 18:10:09]

SINGLE_TOP only works if the download activity is on top; if you open an image
on top of the download activity, then click the notification again, what
happens?

[shaktisahu, 2017-04-04 18:27:38]

On 2017/04/04 18:10:09, dfalcantara (load balance plz) wrote:
> SINGLE_TOP only works if the download activity is on top; if you open an image
> on top of the download activity, then click the notification again, what
> happens?

Yes, it works only when the activity is on top. If there is an image/video on
top, it will open a new download activity on top of that.
I tried using FLAG_ACTIVITY_REORDER_TO_FRONT, but it didn't work. I think the
CCT is launched in a new task, so it will have a different back stack than the
download activity.

[gone, 2017-04-05 00:41:17]

lgtm, but Intent flags continue to scare me.  You'll need to keep a bead on this
in case things go wacky.  I don't suggest putting this in M58 without a lot of
testing with Dave's changes.

[shaktisahu, 2017-04-05 02:27:13]

The CQ bit was checked by shaktisahu@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 03:39:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491359233245060,
"parent_rev": "9f8899a2eceae8c7128fad94d6c44b1a83bb6775", "commit_rev":
"ff530ff4dd4ad565f73d3fb795c9ed4b6ee69e18"}

[commit-bot: I haz the power, 2017-04-05 03:40:05]

Description was changed from

==========
Fixed launching of multiple instances of download home when tapping notification

Without appropriate launch flags, multiple instances for download home
are stacked on top of each other. Using launch mode FLAG_ACTIVITY_SINGLE_TOP
prevents that. Also added flag for FLAG_ACTIVITY_MULTIPLE_TASK in order
for this to work on multi-window scenario.

Verified that this works in Android 6.x and 7.x phones with multi-window.

BUG=692020
==========

to

==========
Fixed launching of multiple instances of download home when tapping notification

Without appropriate launch flags, multiple instances for download home
are stacked on top of each other. Using launch mode FLAG_ACTIVITY_SINGLE_TOP
prevents that. Also added flag for FLAG_ACTIVITY_MULTIPLE_TASK in order
for this to work on multi-window scenario.

Verified that this works in Android 6.x and 7.x phones with multi-window.

BUG=692020

Review-Url: https://codereview.chromium.org/2793613002
Cr-Commit-Position: refs/heads/master@{#461970}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff530ff4dd4ad565f73d3fb795c9...
==========

[commit-bot: I haz the power, 2017-04-05 03:40:06]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff530ff4dd4ad565f73d3fb795c9...