Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2815383002: Revert of Re-enable OOPIF scroll bubbling test. (Closed)

Created:
3 years, 8 months ago by wjmaclean
Modified:
3 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable OOPIF scroll bubbling test. (patchset #1 id:1 of https://codereview.chromium.org/2818733002/ ) Reason for revert: We need to land the DCHECK fix in https://codereview.chromium.org/2814043004/ first. Original issue's description: > Re-enable OOPIF scroll bubbling test. > > Scroll animation breaks this test, so re-enable by setting flag on > mouse wheel events that disable the animation pathway. We'll need a > separate test for the animation pathways at some point. > > BUG=627238 > NO_DEPENDENCY_CHECKS=true > > Review-Url: https://codereview.chromium.org/2818733002 > Cr-Commit-Position: refs/heads/master@{#464434} > Committed: https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e TBR=avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627238 Review-Url: https://codereview.chromium.org/2815383002 Cr-Commit-Position: refs/heads/master@{#464515} Committed: https://chromium.googlesource.com/chromium/src/+/75b40615b6c4f91c40120a7b79ae22c5980a05c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wjmaclean
Created Revert of Re-enable OOPIF scroll bubbling test.
3 years, 8 months ago (2017-04-13 19:36:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815383002/1
3 years, 8 months ago (2017-04-13 19:37:22 UTC) #3
Avi (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-13 19:47:52 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:56:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75b40615b6c4f91c40120a7b79ae...

Powered by Google App Engine
This is Rietveld 408576698