|
|
Chromium Code Reviews|
Created:
3 years, 8 months ago by wjmaclean Modified:
3 years, 8 months ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable OOPIF scroll bubbling test.
Scroll animation breaks this test, so re-enable by setting flag on
mouse wheel events that disable the animation pathway. We'll need a
separate test for the animation pathways at some point.
BUG=627238
NO_DEPENDENCY_CHECKS=true
Review-Url: https://codereview.chromium.org/2818733002
Cr-Commit-Position: refs/heads/master@{#464434}
Committed: https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (12 generated)
The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 ========== to ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 ==========
wjmaclean@chromium.org changed reviewers: + avi@chromium.org
avi@ - Tiny, tiny CL ... can you please take a look?
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wjmaclean@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2814043004 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 ========== to ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by wjmaclean@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492100184071710, "parent_rev":
"97a28284f3b297f32f11bbd84c728c07024ae3af", "commit_rev":
"1ed97c2a3c31e85cadfc73b5e775b17571f0656e"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 NO_DEPENDENCY_CHECKS=true ========== to ========== Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2818733002 Cr-Commit-Position: refs/heads/master@{#464434} Committed: https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2815383002/ by wjmaclean@chromium.org. The reason for reverting is: We need to land the DCHECK fix in https://codereview.chromium.org/2814043004/ first.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
