Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2818733002: Re-enable OOPIF scroll bubbling test. (Closed)

Created:
3 years, 8 months ago by wjmaclean
Modified:
3 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG=627238 NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2818733002 Cr-Commit-Position: refs/heads/master@{#464434} Committed: https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
wjmaclean
avi@ - Tiny, tiny CL ... can you please take a look?
3 years, 8 months ago (2017-04-13 14:32:17 UTC) #5
Avi (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-13 15:03:01 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2814043004 Patch 20001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-13 16:06:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818733002/1
3 years, 8 months ago (2017-04-13 16:16:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e
3 years, 8 months ago (2017-04-13 16:31:20 UTC) #17
wjmaclean
3 years, 8 months ago (2017-04-13 19:36:44 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2815383002/ by wjmaclean@chromium.org.

The reason for reverting is: We need to land the DCHECK fix in
https://codereview.chromium.org/2814043004/ first..

Powered by Google App Engine
This is Rietveld 408576698